[Top] [All Lists]

Re: [PATCH] Netpoll support for Sibyte MAC

To: Atsushi Nemoto <>
Subject: Re: [PATCH] Netpoll support for Sibyte MAC
From: Sergei Shtylyov <>
Date: Tue, 20 Mar 2007 21:35:53 +0300
In-reply-to: <>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;
References: <> <>
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803

Atsushi Nemoto wrote:

NETPOLL support for Sibyte MAC

Signed-off-by: Manish Lachwani <>
Signed-off-by: Deepak Saxena <>

If you added NETPOLL support, do not forget to ensure hard_start_xmit
routine callable from interrupt context (or irq disabled).
See commit bce305f4fe779f29d99d414685243f5da0803254 for example.

You're absolutely right: this driver is very likely to blow up the caller when called with interrupts disabled -- it uses spin_unlock_irq() there! This *must* be fixed.

Atsushi Nemoto

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>