[Top] [All Lists]

Re: [PATCH 0/2] FLATMEM: allow memory to start at pfn != 0 [take #2]

Subject: Re: [PATCH 0/2] FLATMEM: allow memory to start at pfn != 0 [take #2]
From: "Franck Bui-Huu" <>
Date: Mon, 12 Mar 2007 10:47:01 +0100
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed;; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=KLx9g4ywPVEEdJYFd0P5mWC1bIEDA2prGlbtMQe2JF5pj6ReGZvrGVPz/oRnHZxph2VlKHKK3r1+7HKwXmOMfxVhT47VOThaCc+9xpNQgCjqGqGS2u99Qz3yzUpB3kxyIBa17CpQ2ASkDcFc960/TiFgWATSXIcUqYB/hrxYWH4=
Domainkey-signature: a=rsa-sha1; c=nofws;; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=dpSoUUh7huhYbd3gBko8Hn/Nk1tkjzkamtOJWNYvPP7SkyWnoBpUEYYhsWi1jrabDwCsD0bzN8zmpwmJfC1sZe3oKiufn47wIE54PGUU7ryIkw/T4KXp8Ras1EGxeNgFUk7oEngf10r9nhePTdJ5xZW9w3YBZFXC3l+6YNoLPPE=
In-reply-to: <Pine.LNX.4.58.0703101034500.19007@Indigo2.Peter>
Original-recipient: rfc822;
References: <> <Pine.LNX.4.58.0703101034500.19007@Indigo2.Peter>

On 3/10/07, peter fuerst <> wrote:
3) The page_offset adjustment may force fixes in other, not yet blown up,
   places (pmd_phys() cried out lately...).

Not really fair. It crashed lately because until now I was the only
one to use it. And unfortunately I failed to give back this change to
Ralf's tree.

BUT, note that the root cause of this bug is that we did _plain_
address translation instead of using dedicated macro.

So I would say that this patch helps to fix these buggy places.

What can PHYS_OFFSET achieve here - besides obfuscating ?
Are there future uses for it, that justify the contortions ?

How do you deal with fancy cases such as physical memory starting at
0x20000000 for example ?


<Prev in Thread] Current Thread [Next in Thread>