[Top] [All Lists]

Re: [PATCH] MMC: au1xmmc R6 response support

To: Manuel Lauss <>
Subject: Re: [PATCH] MMC: au1xmmc R6 response support
From: Pierre Ossman <>
Date: Thu, 25 Jan 2007 09:31:20 +0100
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <> <> <> <>
User-agent: Thunderbird (X11/20061223)
Manuel Lauss wrote:
> Actually, the bug is that because of MMC_RSP_R6 not being handled in
> the switch in au1xmmc_send_command(), the controller gets told that
> no response is expected. I changed the R6 to R1 in mmc.h, thats why
> it worked in the demoboard, and it also works now on the previously
> thought-to-be-broken HW.

So in order to detect any similar problems in the future, I'd like a
patch that adds a "default:" to that switch statement.

     -- Pierre Ossman

  Linux kernel, MMC maintainer
  PulseAudio, core developer
  rdesktop, core developer

<Prev in Thread] Current Thread [Next in Thread>