[Top] [All Lists]

Re: [PATCH] mips irq cleanups

Subject: Re: [PATCH] mips irq cleanups
From: Atsushi Nemoto <>
Date: Thu, 02 Nov 2006 11:51:53 +0900 (JST)
In-reply-to: <>
Original-recipient: rfc822;
References: <> <>
On Wed, 1 Nov 2006 18:47:55 +0000, Ralf Baechle <> wrote:
> >  37 files changed, 289 insertions(+), 1647 deletions(-)
> Very nice.  I gave it a shot on a Malta and it works just fine.

Thanks!  For most level type irq chips (which initialize .ack, .mask
and .mask_ack rountine with same function), it should be easy to
migrate to new irq flow handler:

1. replace set_irq_chip() with set_irq_chip_and_handler(..., handle_level_irq)
2. use generic_handle_irq() instead of __do_IRQ()

I'm still not sure for per-cpu type irq chips and egdg type irq chips,
especially i8259.  The i8259 seems not suitable for handle_edge_irq or
handle_level_irq yet.  The irq handling on SMP seems another maze ...

Atsushi Nemoto

<Prev in Thread] Current Thread [Next in Thread>