|To:||Thomas Koeller <firstname.lastname@example.org>|
|Subject:||Re: [PATCH] RM9000 serial driver|
|From:||Sergei Shtylyov <email@example.com>|
|Date:||Wed, 30 Aug 2006 15:59:57 +0400|
|Cc:||Yoichi Yuasa <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Thomas Köller <email@example.com>|
|Organization:||MontaVista Software Inc.|
|References:||<firstname.lastname@example.org> <email@example.com> <44F459DD.firstname.lastname@example.org> <email@example.com>|
|User-agent:||Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803|
Hello. Thomas Koeller wrote:
Also, it seems to me that the whole register-mapping stuff conflicts with autodetection, because autoconfig() uses serial_inp() and serial_outp() before the port types, and hence the mapping requirements, are known.
Port types have nothing to do with this. Or at least they hadn't until your recent patch. :-) iotype was used to identify the addressing scheme, and it's alsready known beforehand.
How so? If I do not yet know which hardware I am dealing with, how can I know the iotype?
The iotype is passed to driver when registering the platform device or calling early_serial_setup(). There's absolutely no way for 8250.c to figure it out yourself. Please, review the driver's code more carefully. It was not at all that complex task to copy from the existing Alchemy code...
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||Re: [PATCH] 8250_early console support for au1x00 (again), Rodolfo Giometti|
|Next by Date:||Re: [PATCH] RM9000 serial driver, Russell King|
|Previous by Thread:||Re: [PATCH] RM9000 serial driver, Thomas Koeller|
|Next by Thread:||Re: [PATCH] RM9000 serial driver, Thomas Koeller|
|Indexes:||[Date] [Thread] [Top] [All Lists]|