[Top] [All Lists]

Re: [PATCH] au1000_eth.c Power Management, driver registration and modul

To: Rodolfo Giometti <>
Subject: Re: [PATCH] au1000_eth.c Power Management, driver registration and module support
From: Sergei Shtylyov <>
Date: Wed, 31 May 2006 19:01:02 +0400
Cc:,, Linux-MIPS <>, Jordan Crouse <>
In-reply-to: <>
Organization: MontaVista Software Inc.
Original-recipient: rfc822;
References: <> <> <> <> <> <> <>
User-agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.2) Gecko/20040803

Rodolfo Giometti wrote:


the new version of my patch for au1000_eth.c who should implement:

Also, as suggested by Sergei it:

* uses physical addresses and not KSEG1-based virtual anymore and
  claims/releases the 4-byte MAC enable registers:

   wwpc:~# cat /proc/iomem
   10500000-1050ffff : eth-base
   10520000-10520003 : eth-mac
* assigns to the Ethernet ports two consecutive MAC addresses:

   -            dev->dev_addr[4] += 0x10;
   +                            ((unsigned long) macen_addr);
   +            memcpy(ndev->dev_addr, au1000_mac_addr, 
   +            ndev->dev_addr[5] += 0x01;

   Now that this is merged, Rodolfo's patch should probably preempt mine...
but it looks like something was lost during the transition: I failed to see
where SYS_PINFUNC register is actually read (the comment mentioning this was retained :-) to check whether Ethernet port 1 is enabled (its pins are shared w/GPIO)...


WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>