|To:||Peter Popov <firstname.lastname@example.org>|
|Subject:||Re: [PATCH] Philips PNX8550|
|From:||"Vladimir A. Barinov" <email@example.com>|
|Date:||Wed, 07 Dec 2005 22:39:48 +0300|
|User-agent:||Mozilla Thunderbird 1.0.2-6 (X11/20050513)|
I used a quite different board (STB810), but it's based on the same board dependent code as JBS (i.earch/mips/philips/pnx8550/jbs). I haven't worked withJBS board and I'm not sure if slot=10 is needed for that, but it's really necessary for STB810.The JBS has only 3 pci slots and I tested all three. So the fourth one you added won't do any damage butit's not quite right either.I also has another question - Could you please advice: shall I create a different arch/mips/philips/pnx8550/stb810 and add MACH_PHILIPS_STB810 ID and defconfig or I can use exiting JBS one?Is anything else different that would justify the new directory? If not, perhaps we just need an STB board selection in arch/mips/Kconfig, a defconfig, and an ifdef around that pci slot you sent.
The are only 3 small file in the arch/mips/philips/pnx8550/jbs directory: 1) board_setup.c is the same for STB810 2) init.c may be needs cosmetic changes to identify the board: "Philips PNX8550/JBS" -> "Philips PNX8550/STB810" MACH_PHILIPS_JBS -> MACH_PHILIPS_STB810 I'm not sure are they really needed? 3) irq.map needs change to add slot 10 and remove slot 17 for STB810 board. That's all :)
BTW, regarding your serial driver patch ... I have one outstanding change (small) I still have to make, as requested by rmk. Mind if I forward that email to you so you can take care of it :)?
Yes, please. Vladimir
|<Prev in Thread]||Current Thread||[Next in Thread>|