[Top] [All Lists]

Re: [PATCH] Philips PNX8550

To: "Vladimir A. Barinov" <>
Subject: Re: [PATCH] Philips PNX8550
From: Peter Popov <>
Date: Wed, 7 Dec 2005 11:11:00 -0800 (PST)
In-reply-to: <>
Original-recipient: rfc822;

> I used a quite different board (STB810), but it's
> based on the same board dependent code as JBS (i.e
> arch/mips/philips/pnx8550/jbs). I haven't 
> worked with
> JBS board and I'm not sure if slot=10 is needed for
> that, but it's really necessary for STB810.

The JBS has only 3 pci slots and I tested all three.
So the fourth one you added won't do any damage but
it's not quite right either. 

> I also has another question - Could you please
> advice: shall I create a different
> arch/mips/philips/pnx8550/stb810
> and add MACH_PHILIPS_STB810 ID and defconfig
> or I can use exiting JBS one?

Is anything else different that would justify the new
directory? If not, perhaps we just need an STB board
selection in arch/mips/Kconfig, a defconfig, and an
ifdef around that pci slot you sent.

BTW, regarding your serial driver patch ... I have one
outstanding change (small) I still have to make, as
requested by rmk. Mind if I forward that email to you
so you can take care of it :)?



<Prev in Thread] Current Thread [Next in Thread>