[Top] [All Lists]

Re: Fix zero length sys_cacheflush

To: Atsushi Nemoto <>
Subject: Re: Fix zero length sys_cacheflush
From: Ralf Baechle <>
Date: Wed, 19 Oct 2005 16:57:59 +0100
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <>
User-agent: Mutt/
On Wed, Oct 19, 2005 at 11:22:22PM +0900, Atsushi Nemoto wrote:

> BTW, sparse complains for this "unsigned long __user addr".
> asmlinkage int sys_cacheflush(unsigned long __user addr,
>       unsigned long bytes, unsigned int cache)
> /work/git/linux-mips/arch/mips/mm/cache.c:59:7: warning: dereference of 
> noderef expression
> I suppose the "unsigned long __user addr" means that the "addr"
> variable itself is an userspace object.  So its usage is wrong, isn't
> it?

It didn't complain about this use in the past.  Anyway, time to do another
pass with sparse over the code; sparse developers have invented alot of new
creative warnings ;-)


<Prev in Thread] Current Thread [Next in Thread>