[Top] [All Lists]

Re: [patch 4/5] SiByte fixes for 2.6.12

To: Andy Isaacson <>
Subject: Re: [patch 4/5] SiByte fixes for 2.6.12
From: "Maciej W. Rozycki" <>
Date: Thu, 23 Jun 2005 16:11:51 +0100 (BST)
Cc: Andrew Isaacson <>,
In-reply-to: <>
Original-recipient: rfc822;
References: <> <> <>
On Thu, 23 Jun 2005, Andy Isaacson wrote:

> The code looks like it's structured to be able to be compiled with
> support for multiple CPUs, say, r4k and SB1; using #error would seem to
> prevent that.
> With the code as currently structured, you don't know it's going to be a
> noop until runtime comes along and cpu_has_4ktlb is true...

 Well, I've had a look at the code and it's such a mess.  Obviously 
calling ld_mmu_r4xx0() (or any of the other variants) should not be 
compiled conditionally and more specific cases, i.e. based on PRId values 
should take precedence.  I'll see if I can make it better.


<Prev in Thread] Current Thread [Next in Thread>