On Fri, Apr 01, 2005 at 10:28:04AM +0200, Ulrich Eckhardt wrote:
> I just stumbled over arch/mips/au1000/common/prom.c, which contains a
> defined like this:
> char* prom_getcmdline(void);
> while there are implementations that define the function as
> char* __init prom_getcmdline();
> Further, there are several declarations throughout sourcefiles and in
> include/asm-mips/mips-boards/prom.h and include/asm-mips/sgialib.h. Just grep
> for it and you'll see the mess.
> If anyone tells me which one is right and cares to explain why I hereby
> volunteer to create a patch. ;)
__init was introduced long after prom_getcmdline() and not all definitions
ever got updated. For prototypes where __init doesn't server any useful
purpose other than for the human reader so we generally don't use it.
You've herewith been volunteered ;-)