To: | linux-mips@linux-mips.org |
---|---|
Subject: | Re: [PATCH] au1100fb.c ported from 2.4 to 2.6 |
From: | Ulrich Eckhardt <eckhardt@satorlaser.com> |
Date: | Tue, 8 Feb 2005 15:14:07 +0100 |
Cc: | Christian <c.pellegrin@exadron.com> |
In-reply-to: | <1105523407.5654.18.camel@absolute.ascensit.com> |
Organization: | Sator Laser GmbH |
Original-recipient: | rfc822;linux-mips@linux-mips.org |
References: | <1105523407.5654.18.camel@absolute.ascensit.com> |
Sender: | linux-mips-bounce@linux-mips.org |
User-agent: | KMail/1.7.1 |
Another two suggestions: - you hard-coded the used display in au1100fb.{h,c} with #ifdef CONFIG_WWPC. There is another option already used in arch/mips/au1000/common/setup.c, and that is to append the necessary lines to the kernel commandline if no conflicting arguments are present. - I have removed the comments that say to which field a constant belongs and instead converted au1100fb.h to use new-style initialisers which is just easier to not get wrong. I also added parameters for my display and replaced the #define for uint32. The new file is attached as whole, I didn't know against what to diff it... Could you merge the file and resend the patch? I hope it will get committed then. Uli
|
<Prev in Thread] | Current Thread | [Next in Thread> |
---|---|---|
|
Previous by Date: | Re: Kernel crash on yosemite, Ralf Baechle |
---|---|
Next by Date: | Re: ADM5120: time.c issues ?, Jeroen Vreeken |
Previous by Thread: | Re: [PATCH] au1100fb.c ported from 2.4 to 2.6, Ulrich Eckhardt |
Next by Thread: | [PATCH 20/20] mips/bcm1250_tbprof: remove interruptible_sleep_on() usage, Nishanth Aravamudan |
Indexes: | [Date] [Thread] [Top] [All Lists] |