[Top] [All Lists]

Re: No bzImage target for MIPS

To: Keith Owens <>
Subject: Re: No bzImage target for MIPS
From: Geoffrey Espin <>
Date: Thu, 13 Dec 2001 20:12:10 -0800
Cc: linux-mips <>
In-reply-to: <>; from Keith Owens on Fri, Dec 14, 2001 at 02:51:21PM +1100
References: <> <>

On Fri, Dec 14, 2001 at 02:51:21PM +1100, Keith Owens wrote:
> >#include "../../../fs/jffs2/zlib.c" /**/
> >#include "../../../lib/ctype.c"
> I am phasing out the practice of ../ in kernel include paths.  It is
> much better to do
> #include "zlib.c"
> #include "ctype.c"
> and the Makefile adds -I$(TOPDIR)/fs/jffs2 -I$(TOPDIR)/lib.  Then when

I'll check around the tree.  Doesn't matter to me.  Both have crappy
implications.  I hate it when -I's pile up... and you don't know which
directory takes precedence (esp. if there are duplicate names).

> >TOPDIR          = ../../..
> TOPDIR := $(shell cd ../../..; /bin/pwd)
> is better, it returns an absolute path instead of a relative one.

Hmmm, okay.  I probably shouldn't even have this macro.
I had hacked things earlier so I didn't have to run 'make' from linux/.

Thanks for the quick feedback, mate!

[I'll spare someone pointing out that I should have tried to use
linux/lib/vsprintf.c.  Missed it!  What a newbie.]

Geoffrey Espin

<Prev in Thread] Current Thread [Next in Thread>