[Top] [All Lists]

Re: No bzImage target for MIPS

To: Geoffrey Espin <>
Subject: Re: No bzImage target for MIPS
From: Keith Owens <>
Date: Fri, 14 Dec 2001 14:51:21 +1100
Cc: linux-mips <>
In-reply-to: Your message of "Thu, 13 Dec 2001 19:28:46 -0800." <>
On Thu, 13 Dec 2001 19:28:46 -0800, 
Geoffrey Espin <> wrote:
>#include "../../../fs/jffs2/zlib.c" /**/
>#include "../../../lib/ctype.c"

I am phasing out the practice of ../ in kernel include paths.  It is
much better to do

#include "zlib.c"
#include "ctype.c"

and the Makefile adds -I$(TOPDIR)/fs/jffs2 -I$(TOPDIR)/lib.  Then when
sources are moved from one directory to another, the source does not
change, only the Makefile.  Relative paths are a pain in the neck in
Makefiles, they are even more of a pain in source code.

>TOPDIR          = ../../..

TOPDIR := $(shell cd ../../..; /bin/pwd)

is better, it returns an absolute path instead of a relative one.

Keith Owens, kernel build maintainer

<Prev in Thread] Current Thread [Next in Thread>