From jonas.gorski@gmail.com Fri May 25 23:07:43 2012 Received: with ECARTIS (v1.0.0; list freecwmp); Fri, 25 May 2012 23:07:46 +0200 (CEST) Received: from mail-wi0-f171.google.com ([209.85.212.171]:55887 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903651Ab2EYVHn (ORCPT ); Fri, 25 May 2012 23:07:43 +0200 Received: by wibhm14 with SMTP id hm14so6472856wib.6 for ; Fri, 25 May 2012 14:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:x-mailer; bh=65Mk2cGSx9Te8WVje6Xs+TA3i837PZQ9pKgdXhN+S34=; b=x/WtN32qxc78RoBtIjc9JloHJU+cdPMsoiktxkDCoGsQLdIwd1q0kfReOzgMv8yCXx 1iWTbG72Xti5TB98T1lv3hb+/6J4fOXm5zfScrGmZuDiaQC8jSxMCbzM49smY59Ybf9v /+L3NIuRsbp4v7GnNeKyTTkSMP8j/u5AGkm3p7bv7E0YTJwgxbU8c6yJEjSImGuFPQdy CAT74AYPvzMh1qeyZQvfk+fc0nq8sz1WMNorcg7vg9E0pYvDEZAHFUH/vecbFoUemFpE CpqP1Oq9NqsDko3lH3TP7VXeUiQ37w/NEUWw4i5st9DXQLwZBspqtkIu7AzfIm+sD2T+ dwXA== Received: by 10.181.11.137 with SMTP id ei9mr633980wid.21.1337980057500; Fri, 25 May 2012 14:07:37 -0700 (PDT) Received: from shaker64.lan (dslb-088-073-150-107.pools.arcor-ip.net. [88.73.150.107]) by mx.google.com with ESMTPS id f19sm24302918wiw.11.2012.05.25.14.07.36 (version=SSLv3 cipher=OTHER); Fri, 25 May 2012 14:07:36 -0700 (PDT) From: Jonas Gorski To: freecwmp@linux-mips.org Subject: [PATCH] freecwmp: do not include host's /usr/include Date: Fri, 25 May 2012 23:06:44 +0200 Message-Id: <1337980005-20916-1-git-send-email-jonas.gorski@gmail.com> X-Mailer: git-send-email 1.7.2.5 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s freecwmp"> (uid 0) X-Orcpt: rfc822;freecwmp@linux-mips.org Original-Recipient: rfc822;freecwmp@linux-mips.org X-archive-position: 25 X-ecartis-version: Ecartis v1.0.0 Sender: freecwmp-bounce@linux-mips.org Errors-to: freecwmp-bounce@linux-mips.org X-original-sender: jonas.gorski@gmail.com Precedence: bulk X-list: freecwmp Explicitly set the uci include path, else it defaults to /usr/include. Fixed build failures like: In file included from /usr/include/ctype.h:27:0, from /usr/include/getopt.h:35, from ../src/freecwmp.c:10: /usr/include/features.h:323:26: fatal error: bits/predefs.h: No such file or directory Contributed by T-Labs, Deutsche Telekom Innovation Laboratories Signed-off-by: Jonas Gorski --- freecwmp/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/freecwmp/Makefile b/freecwmp/Makefile index 9470ae4..b8b406e 100644 --- a/freecwmp/Makefile +++ b/freecwmp/Makefile @@ -47,6 +47,9 @@ endif TARGET_LDFLAGS += \ -Wl,-rpath-link=$(STAGING_DIR)/usr/lib +CONFIGURE_ARGS += \ + --with-uci-include-path=$(STAGING_DIR)/usr/include + ifeq ($(CONFIG_FREECWMP_HTTP_ZSTREAM),y) CONFIGURE_ARGS += \ --enable-http=zstream -- 1.7.10 From jonas.gorski@gmail.com Fri May 25 23:07:47 2012 Received: with ECARTIS (v1.0.0; list freecwmp); Fri, 25 May 2012 23:07:50 +0200 (CEST) Received: from mail-wi0-f171.google.com ([209.85.212.171]:43448 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903680Ab2EYVHo (ORCPT ); Fri, 25 May 2012 23:07:44 +0200 Received: by wibhm14 with SMTP id hm14so6472870wib.6 for ; Fri, 25 May 2012 14:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:x-mailer:in-reply-to:references; bh=Y2/v/bN7Xu3VzZsqQkmElIzmZV2WJzxZOH0St8X1jNY=; b=rWCIK3LNglyz4qiHEb6BJie5rzrs2wqeF0W9wDqkkZHthZ++QDSMhRmzELCl514xDE 6ssJFosvPvtM8kI8AafS6iFnaG7Kt8E4jxa1OyUm+ANDTEtd4h08x2IaEocAKzOm2Tfw UbCyeXfVgt+6LfY/kmjFOTvXC75w4X589uba9u0WcdHyjLPCBpiAQuptLGeqp2oAP167 BTY3Wdh097ZDxlMeN6KEJq0+6ruqknjQXqSzss8wM0Hkn4sgd0thCGOtX4NjhlM3CjMp sS8uEzYufOI4+k9/3nKzP6tKc2GYf996Q3TkCoaJ8g7Q1PNm868Fg6pEbJuQah2g3R78 sV8g== Received: by 10.180.81.36 with SMTP id w4mr664530wix.16.1337980058850; Fri, 25 May 2012 14:07:38 -0700 (PDT) Received: from shaker64.lan (dslb-088-073-150-107.pools.arcor-ip.net. [88.73.150.107]) by mx.google.com with ESMTPS id f19sm24302918wiw.11.2012.05.25.14.07.37 (version=SSLv3 cipher=OTHER); Fri, 25 May 2012 14:07:38 -0700 (PDT) From: Jonas Gorski To: freecwmp@linux-mips.org Subject: [PATCH] freecwmp: define code as needing GNU features Date: Fri, 25 May 2012 23:06:45 +0200 Message-Id: <1337980005-20916-2-git-send-email-jonas.gorski@gmail.com> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1337980005-20916-1-git-send-email-jonas.gorski@gmail.com> References: <1337980005-20916-1-git-send-email-jonas.gorski@gmail.com> Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s freecwmp"> (uid 0) X-Orcpt: rfc822;freecwmp@linux-mips.org Original-Recipient: rfc822;freecwmp@linux-mips.org X-archive-position: 26 X-ecartis-version: Ecartis v1.0.0 Sender: freecwmp-bounce@linux-mips.org Errors-to: freecwmp-bounce@linux-mips.org X-original-sender: jonas.gorski@gmail.com Precedence: bulk X-list: freecwmp fixes the following build failure: freecwmpd-external.o: In function `external_download': openwrt/build_dir/target-i386_uClibc-0.9.33/freecwmp-2012-04-30/bin/../src/cwmp/external.c:260: undefined reference to `WIFEXITED' openwrt/build_dir/target-i386_uClibc-0.9.33/freecwmp-2012-04-30/bin/../src/cwmp/external.c:260: undefined reference to `WEXITSTATUS' Contributed by T-Labs, Deutsche Telekom Innovation Laboratories Signed-off-by: Jonas Gorski --- I'm not sure whether this should be fixed in the package Makefile or in freecwmp's Makefile itself, so I chose the easy way and added it to the package Makefile. freecwmp/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/freecwmp/Makefile b/freecwmp/Makefile index b8b406e..0cdbe84 100644 --- a/freecwmp/Makefile +++ b/freecwmp/Makefile @@ -44,6 +44,9 @@ define Build/Prepare endef endif +TARGET_CFLAGS += \ + -D_GNU_SOURCE + TARGET_LDFLAGS += \ -Wl,-rpath-link=$(STAGING_DIR)/usr/lib -- 1.7.10 From freecwmp@lukaperkov.net Sat May 26 01:14:17 2012 Received: with ECARTIS (v1.0.0; list freecwmp); Sat, 26 May 2012 01:14:21 +0200 (CEST) Received: from mail-wg0-f41.google.com ([74.125.82.41]:65205 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903685Ab2EYXOR (ORCPT ); Sat, 26 May 2012 01:14:17 +0200 Received: by wgbds1 with SMTP id ds1so11624wgb.0 for ; Fri, 25 May 2012 16:14:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:x-gm-message-state; bh=levNyd9q8dztvSPzhsmHsp00j9I5QqI3zh4/oLT6l8w=; b=jxGG9eRgtnmVppqR7eyT/trVbZPaDHC2x05o0jiBcMgOP7c4Ti8GbLvqgY8iSxvdjp aSkO9hHPmWs5uEtO4ndL993GNIgXDKAzoXT6gTlW92ZqyV7IM8HnlgI+JxQIcE0aN7j5 VHEeJcRr93RKGC3Gy6IruP5s86yUugpIytXRFjlkZGEpPhQYvA04A2JIK24FVwFePOpF DCbMy0H0o6+4ZxbRoEemyvygVY/gF2l8eQdOMNWVSCHGMbs4hCPwYKrVgtL07GGqkKRN Xs7S+ZAh3Zsc2Iz+Ow0hCL82X3qwsVzGK/iSahZ+ORd7jhy6yzSsy2fKWWJL+K5B+0Rn fiHw== Received: by 10.180.98.39 with SMTP id ef7mr1317551wib.21.1337987652261; Fri, 25 May 2012 16:14:12 -0700 (PDT) Received: from localhost (zg07-033.dialin.iskon.hr. [213.191.150.34]) by mx.google.com with ESMTPS id j4sm164835wiz.1.2012.05.25.16.14.10 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 25 May 2012 16:14:11 -0700 (PDT) Date: Sat, 26 May 2012 01:14:13 +0200 From: Luka Perkov To: Jonas Gorski Cc: freecwmp@linux-mips.org Subject: Re: [PATCH] freecwmp: do not include host's /usr/include Message-ID: <20120525231413.GA26220@w500.iskon.local> Mail-Followup-To: Jonas Gorski , freecwmp@linux-mips.org References: <1337980005-20916-1-git-send-email-jonas.gorski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1337980005-20916-1-git-send-email-jonas.gorski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQnup/iJpF/5+MqBHqmkq7qn0uWqu5ju9QCx+i5jAHJu6WqdqsCUTzHCMlpBk0nnpu6f9qXC Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s freecwmp"> (uid 0) X-Orcpt: rfc822;freecwmp@linux-mips.org Original-Recipient: rfc822;freecwmp@linux-mips.org X-archive-position: 27 X-ecartis-version: Ecartis v1.0.0 Sender: freecwmp-bounce@linux-mips.org Errors-to: freecwmp-bounce@linux-mips.org X-original-sender: freecwmp@lukaperkov.net Precedence: bulk X-list: freecwmp On Fri, May 25, 2012 at 11:06:44PM +0200, Jonas Gorski wrote: > Explicitly set the uci include path, else it defaults to /usr/include. > > Fixed build failures like: > > In file included from /usr/include/ctype.h:27:0, > from /usr/include/getopt.h:35, > from ../src/freecwmp.c:10: > /usr/include/features.h:323:26: fatal error: bits/predefs.h: No such file or directory > > Contributed by T-Labs, Deutsche Telekom Innovation Laboratories Applied in 179c5f094fa60a3bdd10ba230de8552eae7fe4d1. Thank you. Regards, Luka From freecwmp@lukaperkov.net Sat May 26 01:15:04 2012 Received: with ECARTIS (v1.0.0; list freecwmp); Sat, 26 May 2012 01:15:08 +0200 (CEST) Received: from mail-wg0-f43.google.com ([74.125.82.43]:47365 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903684Ab2EYXPE (ORCPT ); Sat, 26 May 2012 01:15:04 +0200 Received: by wgbdr1 with SMTP id dr1so1175091wgb.24 for ; Fri, 25 May 2012 16:14:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:x-gm-message-state; bh=gM2fmrkkTsxjVgLcqcDZC21fFsL3X02FdyKPg37cUCI=; b=eFWcW6Tu2A3r71+3oJszfc1QV9sXVOD9oVidR45R90D1whMCAw/ncH/UWk6KoLTlbd 86G9WqDIxrZxRIWZ4DoWyBDk93ue1OYftkOIpMZRtNJNQUOi67DjxAED252X+Zbq72wW 7ED465K8XUYyfObwKzaYOj9jFLwW+pbkcr3KpZGp8u17GpQhBU3gTbQVS3Pvvu0zESPX YzjoODi4hZ7fjOPndJ5RgnWm93f6eBIoTK/eALkxIzhjmkS3TDK/JBUWASZcKiDFyThQ +D65ODpskcR1RVFSwrIYjRz69l9ltdcnqVKXqjo/VUCLvRzJIyjH/MDXw5zI56KrLWoD rH2w== Received: by 10.180.81.36 with SMTP id w4mr1226320wix.16.1337987699493; Fri, 25 May 2012 16:14:59 -0700 (PDT) Received: from localhost (zg07-033.dialin.iskon.hr. [213.191.150.34]) by mx.google.com with ESMTPS id z8sm266726wiy.1.2012.05.25.16.14.58 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 25 May 2012 16:14:58 -0700 (PDT) Date: Sat, 26 May 2012 01:15:01 +0200 From: Luka Perkov To: Jonas Gorski Cc: freecwmp@linux-mips.org Subject: Re: [PATCH] freecwmp: define code as needing GNU features Message-ID: <20120525231501.GB26220@w500.iskon.local> Mail-Followup-To: Jonas Gorski , freecwmp@linux-mips.org References: <1337980005-20916-1-git-send-email-jonas.gorski@gmail.com> <1337980005-20916-2-git-send-email-jonas.gorski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1337980005-20916-2-git-send-email-jonas.gorski@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQnLDTNLFIrflQ49L3ng1IfJj7sROX/cUdCj0uRxbjpt2oSZ1/dH33oUy8T5c4/XEG600I7V Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s freecwmp"> (uid 0) X-Orcpt: rfc822;freecwmp@linux-mips.org Original-Recipient: rfc822;freecwmp@linux-mips.org X-archive-position: 28 X-ecartis-version: Ecartis v1.0.0 Sender: freecwmp-bounce@linux-mips.org Errors-to: freecwmp-bounce@linux-mips.org X-original-sender: freecwmp@lukaperkov.net Precedence: bulk X-list: freecwmp On Fri, May 25, 2012 at 11:06:45PM +0200, Jonas Gorski wrote: > fixes the following build failure: > > freecwmpd-external.o: In function `external_download': > openwrt/build_dir/target-i386_uClibc-0.9.33/freecwmp-2012-04-30/bin/../src/cwmp/external.c:260: undefined reference to `WIFEXITED' > openwrt/build_dir/target-i386_uClibc-0.9.33/freecwmp-2012-04-30/bin/../src/cwmp/external.c:260: undefined reference to `WEXITSTATUS' > > Contributed by T-Labs, Deutsche Telekom Innovation Laboratories Applied in 2a9f338488b2198c23a258d52cfcd61d58e652f2. Thank you. Regards, Luka From benjamin@southpole.se Tue May 29 16:47:47 2012 Received: with ECARTIS (v1.0.0; list freecwmp); Tue, 29 May 2012 16:47:53 +0200 (CEST) Received: from smtp.bredband2.com ([83.219.192.166]:43184 "EHLO smtp.bredband2.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903730Ab2E2Orr (ORCPT ); Tue, 29 May 2012 16:47:47 +0200 Received: from [10.10.1.127] (h217-27-188-82.cust.tyfon.se [217.27.188.82]) (Authenticated sender: ed8153) by smtp.bredband2.com (Postfix) with ESMTPSA id C881E6CF15 for ; Tue, 29 May 2012 16:47:41 +0200 (CEST) Message-ID: <4FC4E18E.10508@southpole.se> Date: Tue, 29 May 2012 16:47:42 +0200 From: Benjamin Larsson User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20 MIME-Version: 1.0 To: freecwmp@linux-mips.org Subject: [PATCH] compile fix to make it more easy to build on backfire Content-Type: multipart/mixed; boundary="------------030108040903050703050904" Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s freecwmp"> (uid 0) X-Orcpt: rfc822;freecwmp@linux-mips.org Original-Recipient: rfc822;freecwmp@linux-mips.org X-archive-position: 29 X-ecartis-version: Ecartis v1.0.0 Sender: freecwmp-bounce@linux-mips.org Errors-to: freecwmp-bounce@linux-mips.org X-original-sender: benjamin@southpole.se Precedence: bulk X-list: freecwmp This is a multi-part message in MIME format. --------------030108040903050703050904 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit ../src/cwmp/external.c: In function 'external_get_parameter': ../src/cwmp/external.c:91: error: incompatible type for argument 1 of 'wait' ../src/cwmp/external.c: In function 'external_set_parameter_execute': ../src/cwmp/external.c:197: error: incompatible type for argument 1 of 'wait' ../src/cwmp/external.c: In function 'external_simple': ../src/cwmp/external.c:246: error: incompatible type for argument 1 of 'wait' make[4]: *** [freecwmpd-external.o] Error 1 MvH Benjamin Larsson --------------030108040903050703050904 Content-Type: text/x-patch; name="0001-Add-needed-include-for-wait-int-and-changed-to-prope.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Add-needed-include-for-wait-int-and-changed-to-prope.pa"; filename*1="tch" From f371c8b0b8d170327847d93429e08bc32eef7341 Mon Sep 17 00:00:00 2001 From: Benjamin Larsson Date: Tue, 29 May 2012 16:44:28 +0200 Subject: [PATCH] Add needed include for wait(int*) and changed to proper argument type --- src/cwmp/external.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/cwmp/external.c b/src/cwmp/external.c index eb8d117..d34a0d0 100644 --- a/src/cwmp/external.c +++ b/src/cwmp/external.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include "../freecwmp.h" @@ -49,7 +50,7 @@ external_get_parameter(char *name, char **value) { FC_DEVEL_DEBUG("enter"); - int8_t status; + int status; int pfds[2]; if (pipe(pfds) < 0) @@ -128,7 +129,7 @@ int8_t external_set_parameter_write(char *name, char *value) { FC_DEVEL_DEBUG("enter"); - int8_t status; + int status; FILE *fp; if (access(fc_script_set_parameters, R_OK | W_OK | X_OK) != -1) { @@ -217,7 +218,7 @@ int8_t external_simple(char *arg) { FC_DEVEL_DEBUG("enter"); - int8_t status; + int status; if ((uproc.pid = fork()) == -1) { goto error; @@ -264,7 +265,7 @@ external_download(char *url, char *size) { FC_DEVEL_DEBUG("enter"); - int8_t status; + int status; if ((uproc.pid = fork()) == -1) { goto error; -- 1.7.1 --------------030108040903050703050904--