linux-mips
[Top] [All Lists]

Re: [PATCH 1/1] MIPS: Octeon: remove unnecessary null test before debugf

To: Fabian Frederick <fabf@skynet.be>, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 1/1] MIPS: Octeon: remove unnecessary null test before debugfs_remove_recursive
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 30 Jun 2014 10:11:51 -0700
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Y3LeHaEON37+QLbOSbDRunbXQTYt9kvV2+0h6fNdfvI=; b=kiqzSs7lXGMS8TtDKy8iRU5PWnko1mG0UBQ0p9eFEpbGxSZEwIRgkuqyv54M9z5Wm8 7SJIeLbRElpOm128kY5E1E3xva+hwo0wiJn0JumI92R1/ho2LmA9eWMewLJ3aAXv6Mvw MByScEWWEKoaZ2MW6fDmtGdbRZqRpnFMvC6KhqKYeg9bjHvvLjeuUmS6gFU9I/NYwZJV /fbUdCOwwwacDPpBHl+5m+QnNIPkE21adkOWoJ7hYYnwNesLrt7iWvHbwgu2oGM9wp34 fgyRkqHiu3SbjPH5iDzbcxkn/74He/fuCGyuhD3gA6VUHHyYsr1HKYn1viWV9PUSVc2N NCjw==
In-reply-to: <1404026179-2910-1-git-send-email-fabf@skynet.be>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1404026179-2910-1-git-send-email-fabf@skynet.be>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 06/29/2014 12:16 AM, Fabian Frederick wrote:
Fix checkpatch warning:
WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not 
required

Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Signed-off-by: Fabian Frederick <fabf@skynet.be>

I haven't tested it, but it seems fine, so...

Acked-by: David Daney <david.daney@cavium.com>

---
  arch/mips/cavium-octeon/oct_ilm.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/mips/cavium-octeon/oct_ilm.c 
b/arch/mips/cavium-octeon/oct_ilm.c
index 71b213d..2d68a39 100644
--- a/arch/mips/cavium-octeon/oct_ilm.c
+++ b/arch/mips/cavium-octeon/oct_ilm.c
@@ -194,8 +194,7 @@ err_irq:
  static __exit void oct_ilm_module_exit(void)
  {
        disable_timer(TIMER_NUM);
-       if (dir)
-               debugfs_remove_recursive(dir);
+       debugfs_remove_recursive(dir);
        free_irq(OCTEON_IRQ_TIMER0 + TIMER_NUM, 0);
  }




<Prev in Thread] Current Thread [Next in Thread>