linux-mips
[Top] [All Lists]

Re: [PATCH v3 7/9] MIPS: KVM: Fix memory leak on VCPU

To: Paolo Bonzini <pbonzini@redhat.com>, James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH v3 7/9] MIPS: KVM: Fix memory leak on VCPU
From: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>
Date: Fri, 27 Jun 2014 16:47:20 -0700
Cc: <gleb@kernel.org>, <kvm@vger.kernel.org>, <sanjayl@kymasys.com>, <ralf@linux-mips.org>, <linux-mips@linux-mips.org>
In-reply-to: <53AABDE9.3050907@redhat.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1403631071-6012-1-git-send-email-dengcheng.zhu@imgtec.com> <1403631071-6012-8-git-send-email-dengcheng.zhu@imgtec.com> <53AA9625.8020802@imgtec.com> <53AABDE9.3050907@redhat.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
Hi Paolo,


On 06/25/2014 05:17 AM, Paolo Bonzini wrote:
Il 25/06/2014 11:28, James Hogan ha scritto:
On 24/06/14 18:31, Deng-Cheng Zhu wrote:
From: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>

kvm_arch_vcpu_free() is called in 2 code paths:

1) kvm_vm_ioctl()
       kvm_vm_ioctl_create_vcpu()
           kvm_arch_vcpu_destroy()
               kvm_arch_vcpu_free()
2) kvm_put_kvm()
       kvm_destroy_vm()
           kvm_arch_destroy_vm()
               kvm_mips_free_vcpus()
                   kvm_arch_vcpu_free()

Neither of the paths handles VCPU free. We need to do it in
kvm_arch_vcpu_free() corresponding to the memory allocation in
kvm_arch_vcpu_create().

Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>

Reviewed-by: James Hogan <james.hogan@imgtec.com>

Maybe worth adding "Cc: stable@vger.kernel.org" and moving this to the
beginning of the patchset to avoid conflicts.

Cheers
James


I've queued this for 3.16.  It applies cleanly apart for the filename change.

Maybe you forgot to put this on the branch "queue"? I don't see it. Thanks.


Deng-Cheng


<Prev in Thread] Current Thread [Next in Thread>