linux-mips
[Top] [All Lists]

Re: [PATCH v4 5/7] MIPS: KVM: Rename files to remove the prefix "kvm_" a

To: James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH v4 5/7] MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_"
From: David Daney <ddaney.cavm@gmail.com>
Date: Thu, 26 Jun 2014 17:32:22 -0700
Cc: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>, Paolo Bonzini <pbonzini@redhat.com>, Gleb Natapov <gleb@kernel.org>, kvm@vger.kernel.org, Sanjay Lal <sanjayl@kymasys.com>, Ralf Baechle <ralf@linux-mips.org>, Linux MIPS Mailing List <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=XLf0OwuF97/uSCr2YqIaYUgLEPJgz+FDSfJBrNa751M=; b=RZU6xtcz3m2mTWCOuHFAPsCJlI5sSwsgojYaD+x3EBzwosP6jxqvMkJPiX2zJ3NZ+R fQx2LIsZCspCa/39ewuRSrnC1/O44CJuJC1vb5nKS+8LE7b+lGnO3cd50lcAJD981Igq ZdqDWXwXF9paJEn36M+wgotzu5Zx+FqeTMKD8uGxs0VfwZOfokF1ZBC/VN7LSry4mD3R fM54XW7IS/npa0oIYsDM1fERb1CGNe4RgaGKUpquzAKSI23w7HtGZoHjqXCa/TINSeIG er7dVhfkQ/EdJqRMhq8o8FfPN2emRNRPVIzwY/XNQlUuVhS6TglGvH029iIQoayHIkQE Imog==
In-reply-to: <CAAG0J99aDdsku1ZXX=aBxK4NVwEZK2wa+gV638yZN735qZnT+A@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1403809900-17454-1-git-send-email-dengcheng.zhu@imgtec.com> <1403809900-17454-6-git-send-email-dengcheng.zhu@imgtec.com> <53AC7466.6070401@gmail.com> <53AC7AAD.7010007@imgtec.com> <53AC96D7.8040208@gmail.com> <CAAG0J99aDdsku1ZXX=aBxK4NVwEZK2wa+gV638yZN735qZnT+A@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 06/26/2014 04:21 PM, James Hogan wrote:
On 26 June 2014 22:55, David Daney <ddaney.cavm@gmail.com> wrote:
There is precedence in x86 for some of the names though.

But really why churn up the code in the first place?  the kvm_mips
prefix does tell us exactly what we are dealing with.


That's why people created the arch/mips/kvm directory, isn't it?


No.  Segregating things into directories keeps code related to one
functional area together.

File names are different.  They should carry as much meaning as possible.

For examples of this look at some of these directories:

drivers/net/ethernet/intel/ixgb
drivers/i2c/busses

It is not bad to have a filename prefix related to the function of the
files.

Hi David,

More importantly if you look in arch/*/kvm/, very few of the files
have kvm in their names except for mips.

Personally I find the filenames Deng-Cheng is suggesting must less
cumbersome to type. Most of the files start with kvm_mips_ at the
moment, which is completely redundant.

As for churn, renaming the files hardly produces much churn compared
to cleaning up coding style issues like some of the other patches, but
I still think even they are worth doing.

I have expressed my opinion.  I don't want to spend any more time on it.

Let the maintainers decide what they want to do.

David Daney


<Prev in Thread] Current Thread [Next in Thread>