linux-mips
[Top] [All Lists]

Re: [PATCH v4 5/7] MIPS: KVM: Rename files to remove the prefix "kvm_" a

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH v4 5/7] MIPS: KVM: Rename files to remove the prefix "kvm_" and "kvm_mips_"
From: James Hogan <james.hogan@imgtec.com>
Date: Fri, 27 Jun 2014 00:21:49 +0100
Cc: Deng-Cheng Zhu <dengcheng.zhu@imgtec.com>, Paolo Bonzini <pbonzini@redhat.com>, Gleb Natapov <gleb@kernel.org>, kvm@vger.kernel.org, Sanjay Lal <sanjayl@kymasys.com>, Ralf Baechle <ralf@linux-mips.org>, Linux MIPS Mailing List <linux-mips@linux-mips.org>, James Hogan <james.hogan@imgtec.com>
In-reply-to: <53AC96D7.8040208@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1403809900-17454-1-git-send-email-dengcheng.zhu@imgtec.com> <1403809900-17454-6-git-send-email-dengcheng.zhu@imgtec.com> <53AC7466.6070401@gmail.com> <53AC7AAD.7010007@imgtec.com> <53AC96D7.8040208@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On 26 June 2014 22:55, David Daney <ddaney.cavm@gmail.com> wrote:
>>> There is precedence in x86 for some of the names though.
>>>
>>> But really why churn up the code in the first place?  the kvm_mips
>>> prefix does tell us exactly what we are dealing with.
>>
>>
>> That's why people created the arch/mips/kvm directory, isn't it?
>
>
> No.  Segregating things into directories keeps code related to one
> functional area together.
>
> File names are different.  They should carry as much meaning as possible.
>
> For examples of this look at some of these directories:
>
> drivers/net/ethernet/intel/ixgb
> drivers/i2c/busses
>
> It is not bad to have a filename prefix related to the function of the
> files.

Hi David,

More importantly if you look in arch/*/kvm/, very few of the files
have kvm in their names except for mips.

Personally I find the filenames Deng-Cheng is suggesting must less
cumbersome to type. Most of the files start with kvm_mips_ at the
moment, which is completely redundant.

As for churn, renaming the files hardly produces much churn compared
to cleaning up coding style issues like some of the other patches, but
I still think even they are worth doing.

Cheers
James

<Prev in Thread] Current Thread [Next in Thread>