linux-mips
[Top] [All Lists]

Re: [PATCH v8 4/9] sched: move no_new_privs into new atomic flags

To: Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH v8 4/9] sched: move no_new_privs into new atomic flags
From: Kees Cook <keescook@chromium.org>
Date: Wed, 25 Jun 2014 07:44:15 -0700
Cc: LKML <linux-kernel@vger.kernel.org>, Andy Lutomirski <luto@amacapital.net>, "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>, Alexei Starovoitov <ast@plumgrid.com>, Andrew Morton <akpm@linux-foundation.org>, Daniel Borkmann <dborkman@redhat.com>, Will Drewry <wad@chromium.org>, Julien Tinnes <jln@chromium.org>, David Drysdale <drysdale@google.com>, Linux API <linux-api@vger.kernel.org>, "x86@kernel.org" <x86@kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, linux-mips@linux-mips.org, linux-arch <linux-arch@vger.kernel.org>, linux-security-module <linux-security-module@vger.kernel.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=d43c9ia4W4ibB4JXNGaNqBdNylfjX3ysbsOgdxFdABQ=; b=pSR8s9nSTMeCY9F0OMYJdEYif0/yXCCV5+NiA/h0yR8/ZJKUtIWldrS+1P5tL5Uxul TqSdu6PyLebwqai41geFrbx6s7SyWtIb03SrCNLsNPb/4SD/yIj/R13Fl4rDANHFbgdJ NeKAA8R+ZWzfW/agrJ/ciQSkegpmDNwx+hlk6cYEw55ZNmhEWIGpe4HOekmA+a/YJ3Wt LY4Joh3g1aYtlFsnZs/V3vHy31iiYIGqi5bQITVtokBnnsoDDXU/e95pfy59fj6aIklc 3vPmUigJY/K06oy76LWF956od0EW1mio5qDOL6+zzhttDlG5FBM22ZSGF8rzWUqMa86R q5Fg==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=d43c9ia4W4ibB4JXNGaNqBdNylfjX3ysbsOgdxFdABQ=; b=fMzddH57Z/xmEibz7xXs7FF6S6wSVYYC7fcXbomx9TZ+MKKNQLVr/N8N+g8c4XIPrN D4NQimXx0KwHMMY1AgFJ9gqtG7jXHZb2HwirLxFB+dqB7GLT7Rgt+djhKJtseC7FqJs4 Mi0hg9PyQeW4HEDRwyyIuBlKCVLscpQkfKBWs=
In-reply-to: <20140625134354.GA7892@redhat.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1403642893-23107-1-git-send-email-keescook@chromium.org> <1403642893-23107-5-git-send-email-keescook@chromium.org> <20140625134354.GA7892@redhat.com>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Jun 25, 2014 at 6:43 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> On 06/24, Kees Cook wrote:
>>
>> --- a/include/linux/sched.h
>> +++ b/include/linux/sched.h
>> @@ -1307,8 +1307,7 @@ struct task_struct {
>>                                * execve */
>>       unsigned in_iowait:1;
>>
>> -     /* task may not gain privileges */
>> -     unsigned no_new_privs:1;
>> +     unsigned long atomic_flags; /* Flags needing atomic access. */
>>
>>       /* Revert to default priority/policy when forking */
>>       unsigned sched_reset_on_fork:1;
>
> Agreed, personally I like it more than seccomp->flags.
>
> But probably it would be better to place the new member before/after
> other bitfields to save the space?

Sure, I'll move it down. (Though I thought the compiler was smarter about that.)

-Kees

-- 
Kees Cook
Chrome OS Security

<Prev in Thread] Current Thread [Next in Thread>