linux-mips
[Top] [All Lists]

Re: [PATCH v2] MIPS: Implement random_get_entropy with CP0 Random

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH v2] MIPS: Implement random_get_entropy with CP0 Random
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Mon, 23 Jun 2014 23:11:29 +0100 (BST)
Cc: John Crispin <blogic@openwrt.org>, David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org
In-reply-to: <20140530191808.GO5157@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <alpine.LFD.2.11.1404062102130.15266@eddie.linux-mips.org> <20140530191808.GO5157@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.11 (LFD 23 2013-08-11)
On Fri, 30 May 2014, Ralf Baechle wrote:

> > linux-mips-cycles.patch
> > Index: linux-20140404-4maxp64/arch/mips/include/asm/timex.h
> > ===================================================================
> > --- linux-20140404-4maxp64.orig/arch/mips/include/asm/timex.h
> > +++ linux-20140404-4maxp64/arch/mips/include/asm/timex.h
> > @@ -4,15 +4,18 @@
> >   * for more details.
> >   *
> >   * Copyright (C) 1998, 1999, 2003 by Ralf Baechle
> > + * Copyright (C) 2014 by Maciej W. Rozycki
> >   */
> >  #ifndef _ASM_TIMEX_H
> >  #define _ASM_TIMEX_H
> >  
> >  #ifdef __KERNEL__
> >  
> > +#include <linux/compiler.h>
> > +
> > +#include <asm/cpu.h>
> >  #include <asm/cpu-features.h>
> >  #include <asm/mipsregs.h>
> > -#include <asm/cpu-type.h>
> 
> And this line broke the build big time - lots of files are using either
> boot_cpu_type() or current_cpu_type() and are implicitly getting the
> definition via <asm/timex.h>.
> 
> So for the moment I've added the unnecessary inclusion of asm/cpu-type.h
> back.

 Thanks for fixing this up for me.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH v2] MIPS: Implement random_get_entropy with CP0 Random, Maciej W. Rozycki <=