linux-mips
[Top] [All Lists]

Re: [PATCH 19/31] MIPS: Replace __get_cpu_var uses in FPU emulator.

To: Christoph Lameter <cl@linux.com>, linux-mips <linux-mips@linux-mips.org>
Subject: Re: [PATCH 19/31] MIPS: Replace __get_cpu_var uses in FPU emulator.
From: David Daney <ddaney.cavm@gmail.com>
Date: Fri, 20 Jun 2014 13:07:36 -0700
Cc: Tejun Heo <tj@kernel.org>, akpm@linuxfoundation.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Thomas Gleixner <tglx@linutronix.de>, David Daney <david.daney@cavium.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=RM//3/y0LZCtaUvk0KNEd4zwAavkPH+swvPBlbW0EKU=; b=X6R77r1DvnprWpNBw6H+oGYWMgW8oWGsZf21drV+Iw8O41VVHoypzySbpS7GuFqeoL F2u1o034rJmiB9JZcBuXmJyPipcqZ5RWAEWTTUP+PNriFiIxt7HER10W4qqbzC02PqMu yqnY3IayA79lLMRgAyseYm9AtGa0MeMzjWvK0leGyQQ06F6Z5yZAH66xboSBlF8lrUqf 0IIYkoB6pimp/tc2X2IjbCNZETvdxVNITXTVOmHgEPnianyh2hicl8wDKz8mZnt+uUdf 5lwjIF/HzTkg9Sbvpq3EQAGmHl0l+aCAXe01C1A3lbufzCC5JUIKEjPiOKnsmNr7gEcW kdwg==
In-reply-to: <20140620193127.123705312@linux.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20140620193115.547427118@linux.com> <20140620193127.123705312@linux.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
+ linux-mips@linux-mips.org, as that is the main MIPS patch reviewing list.

On 06/20/2014 12:31 PM, Christoph Lameter wrote:
From: David Daney<david.daney@cavium.com>

The use of __this_cpu_inc() requires a fundamental integer type, so
change the type of all the counters to unsigned long, which is the
same width they were before, but not wrapped in local_t.

Signed-off-by: David Daney<david.daney@cavium.com>
Signed-off-by: Christoph Lameter<cl@linux.com>
---
  arch/mips/include/asm/fpu_emulator.h | 14 +++++++-------
  arch/mips/math-emu/cp1emu.c          |  6 +++---
  2 files changed, 10 insertions(+), 10 deletions(-)

Index: linux/arch/mips/include/asm/fpu_emulator.h
===================================================================
--- linux.orig/arch/mips/include/asm/fpu_emulator.h     2014-06-16 
09:15:42.199326017 -0500
+++ linux/arch/mips/include/asm/fpu_emulator.h  2014-06-16 09:17:42.776959733 
-0500
@@ -33,17 +33,17 @@
  #ifdef CONFIG_DEBUG_FS

  struct mips_fpu_emulator_stats {
-       local_t emulated;
-       local_t loads;
-       local_t stores;
-       local_t cp1ops;
-       local_t cp1xops;
-       local_t errors;
-       local_t ieee754_inexact;
-       local_t ieee754_underflow;
-       local_t ieee754_overflow;
-       local_t ieee754_zerodiv;
-       local_t ieee754_invalidop;
+       unsigned long emulated;
+       unsigned long loads;
+       unsigned long stores;
+       unsigned long cp1ops;
+       unsigned long cp1xops;
+       unsigned long errors;
+       unsigned long ieee754_inexact;
+       unsigned long ieee754_underflow;
+       unsigned long ieee754_overflow;
+       unsigned long ieee754_zerodiv;
+       unsigned long ieee754_invalidop;
  };

  DECLARE_PER_CPU(struct mips_fpu_emulator_stats, fpuemustats);
@@ -51,7 +51,7 @@
  #define MIPS_FPU_EMU_INC_STATS(M)                                     \
  do {                                                                  \
        preempt_disable();                                              \
-       __local_inc(&__get_cpu_var(fpuemustats).M);                 \
+       __this_cpu_inc(fpuemustats.M);                                  \
        preempt_enable();                                               \
  } while (0)




<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 19/31] MIPS: Replace __get_cpu_var uses in FPU emulator., David Daney <=