linux-mips
[Top] [All Lists]

Re: [PATCH] mips: n32: use compat getsockopt syscall

To: Sorin Dumitru <sdumitru@ixiacom.com>, <linux-kernel@vger.kernel.org>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH] mips: n32: use compat getsockopt syscall
From: James Hogan <james.hogan@imgtec.com>
Date: Fri, 20 Jun 2014 11:50:39 +0100
Cc: <ralf@linux-mips.org>
In-reply-to: <53A40FB0.2020503@ixiacom.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1403250786-9763-1-git-send-email-sdumitru@ixiacom.com> <53A404D2.3030303@imgtec.com> <53A40FB0.2020503@ixiacom.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
On 20/06/14 11:40, Sorin Dumitru wrote:
> On 06/20/14 12:54, James Hogan wrote:
>> On 20/06/14 08:53, Sorin Dumitru wrote:
>>> Signed-off-by: Sorin Dumitru <sdumitru@ixiacom.com>
>>
>> A little more commit message wouldn't hurt. Did it break a particular
>> program?
> 
> Yes, it was found by an internal program trying to get IP_PKTOPTIONS on
> a cavium octeon board.
> 
> Should I resubmit stating what was broken in the commit message?

Yeh, if you don't mind. I think it's useful to know exactly why a change
was made and what it fixes when later digging through the git history
(e.g. commit 515c7af85ed9 is a great example of that).

Thanks
James

<Prev in Thread] Current Thread [Next in Thread>