linux-mips
[Top] [All Lists]

Re: [PATCH] mips: n32: use compat getsockopt syscall

To: Sorin Dumitru <sdumitru@ixiacom.com>, <linux-kernel@vger.kernel.org>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH] mips: n32: use compat getsockopt syscall
From: James Hogan <james.hogan@imgtec.com>
Date: Fri, 20 Jun 2014 10:54:26 +0100
Cc: <ralf@linux-mips.org>
In-reply-to: <1403250786-9763-1-git-send-email-sdumitru@ixiacom.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1403250786-9763-1-git-send-email-sdumitru@ixiacom.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0
On 20/06/14 08:53, Sorin Dumitru wrote:
> Signed-off-by: Sorin Dumitru <sdumitru@ixiacom.com>

A little more commit message wouldn't hurt. Did it break a particular
program?

It's consistent with compat_sys_socketcall(), include/uapi/asm/unistd.h,
and commit 515c7af85ed9 (which does same thing for x32) though so it
looks good to me.

Reviewed-by: James Hogan <james.hogan@imgtec.com>

Cheers
James

> ---
>  arch/mips/kernel/scall64-n32.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
> index c1dbcda..e543861 100644
> --- a/arch/mips/kernel/scall64-n32.S
> +++ b/arch/mips/kernel/scall64-n32.S
> @@ -162,7 +162,7 @@ EXPORT(sysn32_call_table)
>       PTR     sys_getpeername
>       PTR     sys_socketpair
>       PTR     compat_sys_setsockopt
> -     PTR     sys_getsockopt
> +     PTR     compat_sys_getsockopt
>       PTR     __sys_clone                     /* 6055 */
>       PTR     __sys_fork
>       PTR     compat_sys_execve
> 

<Prev in Thread] Current Thread [Next in Thread>