linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] MIPS: OCTEON: SMP: delete redundant check

To: Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH 1/3] MIPS: OCTEON: SMP: delete redundant check
From: David Daney <ddaney.cavm@gmail.com>
Date: Tue, 17 Jun 2014 15:31:01 -0700
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=rDJj3Q9vv5J3QnH7HXdpEBYcJph96w+ZlOfAEa5irCI=; b=fDX9FTpql2xBLVKBgdFZvTMxtDk41CQh6/91U2tl6Nga7E+ACN5qZiCxy23qFIJnBh 15vHA0YDmPY4AJprZNM+6VylyfDlG7rby0AUgsBJBJLaY6X4RPzlWbfxqBxMbO3RiT8n g7hNoULgcYA/XvQ18DRfEsO5QcjnOp4HAGLftZ8PWEoQ4xt6V6MS+01D6hpaqyjTIlmA ec2o+mAsqp73GjTkg+ZvoiMDkjuv7L7DekGV59tPxt7iXZv+uZHVNMBBLUYlNAYPunsZ rzQwQh/YikQ+tVm6AKWCOYaEYzpe3CNDqdIFafLm/vr3ea1OGyw0loxmn0ABs5FnKBnO XZNg==
In-reply-to: <1402949190-28182-1-git-send-email-aaro.koskinen@iki.fi>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1402949190-28182-1-git-send-email-aaro.koskinen@iki.fi>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 06/16/2014 01:06 PM, Aaro Koskinen wrote:
The same check is already done earlier in octeon_smp_hotplug_setup().

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>

This seems fine, we want to move away from panicking the kernel towards runtime detection of capabilities. This is certainly no worse in that regard.

Acked-by: David Daney <david.daney@cavium.com>


---
  arch/mips/cavium-octeon/smp.c | 8 --------
  1 file changed, 8 deletions(-)

diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
index a7b3ae1..2c8d156 100644
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -192,14 +192,6 @@ static void octeon_init_secondary(void)
   */
  void octeon_prepare_cpus(unsigned int max_cpus)
  {
-#ifdef CONFIG_HOTPLUG_CPU
-       struct linux_app_boot_info *labi;
-
-       labi = (struct linux_app_boot_info 
*)PHYS_TO_XKSEG_CACHED(LABI_ADDR_IN_BOOTLOADER);
-
-       if (labi->labi_signature != LABI_SIGNATURE)
-               panic("The bootloader version on this board is incorrect.");
-#endif
        /*
         * Only the low order mailbox bits are used for IPIs, leave
         * the other bits alone.



<Prev in Thread] Current Thread [Next in Thread>