linux-mips
[Top] [All Lists]

Re: gcc warning in my trace_benchmark() code

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: gcc warning in my trace_benchmark() code
From: "Maciej W. Rozycki" <macro@linux-mips.org>
Date: Thu, 5 Jun 2014 22:38:05 +0100 (BST)
Cc: David Daney <ddaney.cavm@gmail.com>, Steven Rostedt <rostedt@goodmis.org>, linux-mips@linux-mips.org
In-reply-to: <20140605210718.GV17197@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20140605121204.18ee5f2d@gandalf.local.home> <5390A4F0.3000601@gmail.com> <20140605210718.GV17197@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.11 (LFD 23 2013-08-11)
On Thu, 5 Jun 2014, Ralf Baechle wrote:

> > Ralf:  As a side note, while looking at
> > arch/mips/include/asm/div64.h, I saw that the implementation of
> > __div64_32 in that file will be unused, and is also completely
> > broken due to the first parameter never being used.
> 
> Seems I broke c21004cd5b4cb7d479514d470a62366e8307412c "MIPS: Rewrite
> <asm/div64.h> to work with gcc 4.4.0."  Took only five years until
> somebody noticed ...

 Well, it's not really possible to track all the breakage introduced 
unless at least a warning is spat for some config.  Which is why I think 
it's a good idea to have all non-trivial changes put through a review 
process or at least posted to the relevant mailing list.

 This change didn't appear anywhere, only the commit log message was 
posted, so there was no chance to spot the damage, unless there was 
someone who actively studied changes made to the tree.

  Maciej

<Prev in Thread] Current Thread [Next in Thread>