linux-mips
[Top] [All Lists]

gcc warning in my trace_benchmark() code

To: Ralf Baechle <ralf@linux-mips.org>
Subject: gcc warning in my trace_benchmark() code
From: Steven Rostedt <rostedt@goodmis.org>
Date: Thu, 5 Jun 2014 12:12:04 -0400
Cc: linux-mips@linux-mips.org
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
I'm going through some of the warnings that Fengguang Wu's test bot has
discovered, and one of them is from a MIPS allmodconfig build.

https://lists.01.org/pipermail/kbuild-all/2014-May/004751.html

   kernel/trace/trace_benchmark.c: In function 'trace_do_benchmark':
>> kernel/trace/trace_benchmark.c:84:3: warning: comparison of distinct pointer 
>> types lacks a cast [enabled by default]
>> kernel/trace/trace_benchmark.c:85:3: warning: comparison of distinct pointer 
>> types lacks a cast [enabled by default]
   kernel/trace/trace_benchmark.c:38:6: warning: unused variable 'seedsq' 
[-Wunused-variable]

vim +84 kernel/trace/trace_benchmark.c

    78          if (bm_cnt > 1) {
    79                  /*
    80                   * Apply Welford's method to calculate standard 
deviation:
    81                   * s^2 = 1 / (n * (n-1)) * (n * \Sum (x_i)^2 - (\Sum 
x_i)^2)
    82                   */
    83                  stddev = (u64)bm_cnt * bm_totalsq - bm_total * bm_total;
  > 84                  do_div(stddev, bm_cnt);
  > 85                  do_div(stddev, bm_cnt - 1);
    86          } else
    87                  stddev = 0;
    88  



Is there something special with do_div in mips that I should be aware
of?

-- Steve

<Prev in Thread] Current Thread [Next in Thread>