linux-mips
[Top] [All Lists]

RE: [PATCH v2 0/2] MIPS: ftrace: Fix icache flush issue

To: Viller Hsiao <villerhsiao@gmail.com>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: RE: [PATCH v2 0/2] MIPS: ftrace: Fix icache flush issue
From: Qais Yousef <Qais.Yousef@imgtec.com>
Date: Mon, 24 Feb 2014 09:27:18 +0000
Accept-language: en-GB, en-US
Cc: "rostedt@goodmis.org" <rostedt@goodmis.org>, "fweisbec@gmail.com" <fweisbec@gmail.com>, "mingo@redhat.com" <mingo@redhat.com>, "ralf@linux-mips.org" <ralf@linux-mips.org>
In-reply-to: <1393055209-28251-1-git-send-email-villerhsiao@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1393055209-28251-1-git-send-email-villerhsiao@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
Thread-index: AQHPL6JcK+Nwc65iykWvWXFmMBBmC5rEJTJg
Thread-topic: [PATCH v2 0/2] MIPS: ftrace: Fix icache flush issue
> -----Original Message-----
> From: Viller Hsiao [mailto:villerhsiao@gmail.com]
> Sent: 22 February 2014 07:47
> To: linux-mips@linux-mips.org
> Cc: rostedt@goodmis.org; fweisbec@gmail.com; mingo@redhat.com; ralf@linux-
> mips.org; Qais Yousef; Viller Hsiao
> Subject: [PATCH v2 0/2] MIPS: ftrace: Fix icache flush issue
> 
> In 32-bit mode, the start address of flushing icache is wrong because of error
> address calculation. It causes system crash at boot when dynamic function 
> trace is
> enabled. This issue existed since linux-3.8.
> 
> In the patch set, I fixed the flushing range and refined the macros used by 
> it to
> pass compilation.
> 
> Patch 1 is tried to improve the usability of some macros such that we can make
> patch 2 cleaner. Patch 2 fixes this issue.
> 
> This patch set is based on commit 7d3f1a5 of mips-for-linux-next branch.
> 
> Viller Hsiao (2):
>   MIPS: ftrace: Tweak safe_load()/safe_store() macros
>   MIPS: ftrace: Fix icache flush range error
> 

Both patches look good to me. Thanks for the fixes.

Reviewed-by: Qais Yousef <qais.yousef@imgtec.com>

Qais

>  arch/mips/include/asm/ftrace.h | 20 ++++++++++----------
>  arch/mips/kernel/ftrace.c      |  5 ++---
>  2 files changed, 12 insertions(+), 13 deletions(-)
> 
> --
> 1.8.4.3



<Prev in Thread] Current Thread [Next in Thread>