linux-mips
[Top] [All Lists]

Re: [PATCH] samples/seccomp/Makefile: Do not build tests if cross-compil

To: Markos Chandras <Markos.Chandras@imgtec.com>
Subject: Re: [PATCH] samples/seccomp/Makefile: Do not build tests if cross-compiling for MIPS
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Tue, 18 Feb 2014 23:21:09 -0500
Cc: David Daney <ddaney.cavm@gmail.com>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>
In-reply-to: <53020D12.6060000@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1392312460-24902-1-git-send-email-markos.chandras@imgtec.com> <52FD0F46.6040503@gmail.com> <CAP=VYLr1D-DQz8U4naa5aEL_AFa_JkO5e+TgFSxpsd_2t3dahQ@mail.gmail.com> <53020D12.6060000@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
[Re: [PATCH] samples/seccomp/Makefile: Do not build tests if cross-compiling 
for MIPS] On 17/02/2014 (Mon 13:22) Markos Chandras wrote:

> On 02/14/2014 01:33 AM, Paul Gortmaker wrote:
> >On Thu, Feb 13, 2014 at 1:30 PM, David Daney <ddaney.cavm@gmail.com> wrote:
> >>Really I think we should add a Kconfig item for this and disable the whole
> >>directory for targets that do not support it.
> >
> >Can we do something based on  CONFIG_CROSS_COMPILE vs. adding more Kconfig?
> >
> >Paul.
> >--
> 
> Hi Paul,
> 
> I am not sure how this would solve anything. CONFIG_CROSS_COMPILE
> could be empty, but you can still use 'make
> CROSS_COMPILE=mips-linux-foobar-' or whatever to cross-compile for
> MIPS. So using this symbol to disable tests does not seem right to
> me.
> 
> Another Kconfig symbol should be more appropriate but as far as I
> can see MIPS is the only architecture which has this problem (or I
> may have missed all{yes,mod}config failures from other
> architectures).
> 
> I still think that an "ifndef CONFIG_MIPS" is good enough for now
> until more architectures suffer from this problem in the future. So
> far (and looking at the git history of that file) other
> architectures managed to workaround this.

I don't have a specific preference to any one fix over another; I leave
that to the seccomp folks who review the fix.  But I would like to see
it dealt with ASAP.  The regression has been in linux-next for roughly a
week now, and doing that can mask us from seeing other build regressions
silently stacking up behind this one.  

Thanks,
Paul.
--

> 
> -- markos
> 

<Prev in Thread] Current Thread [Next in Thread>