linux-mips
[Top] [All Lists]

[PATCH] cpuidle/mips: remove redundant cpuidle_idle_call()

To: Paul Burton <paul.burton@imgtec.com>
Subject: [PATCH] cpuidle/mips: remove redundant cpuidle_idle_call()
From: Nicolas Pitre <nico@fluxnic.net>
Date: Mon, 17 Feb 2014 11:09:45 -0500 (EST)
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Daniel Lezcano <daniel.lezcano@linaro.org>, linux-pm@vger.kernel.org, linux-mips@linux-mips.org
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.11 (LFD 23 2013-08-11)
The core idle loop now takes care of it.

Signed-off-by: Nicolas Pitre <nico@linaro.org>
---

I noticed commit c0b5d598aefda in linux-next adds a call to 
cpuidle_idle_call().  At the same time we're rationalizing the idle 
handling code in order to integrate it with the scheduler proper.  
Please note that a similar patch to the one below will be necessary once 
everything gets merged together.

diff --git a/arch/mips/kernel/idle.c b/arch/mips/kernel/idle.c
index 4b1554b3f5..2d753de5dc 100644
--- a/arch/mips/kernel/idle.c
+++ b/arch/mips/kernel/idle.c
@@ -253,8 +253,7 @@ static void mips_cpu_idle(void)
 
 void arch_cpu_idle(void)
 {
-       if (cpuidle_idle_call())
-               mips_cpu_idle();
+       mips_cpu_idle();
 }
 
 #ifdef CONFIG_CPU_IDLE

<Prev in Thread] Current Thread [Next in Thread>