linux-mips
[Top] [All Lists]

Re: [PATCH 14/15] mips: panic if vector register partitioning is impleme

To: Paul Burton <paul.burton@imgtec.com>
Subject: Re: [PATCH 14/15] mips: panic if vector register partitioning is implemented
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 27 Jan 2014 11:56:07 -0800
Cc: linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=IastCxmya6KJyReF0aEz4FhneOIaw8Mw9f3ilX1xVV4=; b=eV/Pj5oAq3qR/BOlfjglFRkWLMp5u7EYULL0SOtwE4LrV1zRXmym7N4kmHm7HnwyR9 wwowg2ZwFidSQJud1MMWcoi0W4DjENTqQfAdiHiOhYjpiomK/z/NdJve5Ph0B13B0tcA U+BG7UV3vxozwV7tDcrpHVNIQOZJinShVkjs7EJCEPygfyr8xF5wCEDQOVc/bcAx9BvB k6UAG0YO9YDwR3hZ9No6PL/j+fvsAgfu1WeO6Oo61M/VnWReKXBuFrSXWtoyAMXOq3ID kj1osizfE0y+e/I1wsv8k8/jUz3I78n47QRKqRQdutf9kSULx7F9SSJhCF7Xbs3ArRyg RnNQ==
In-reply-to: <20140127193908.GL970@pburton-linux.le.imgtec.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1390836194-26286-1-git-send-email-paul.burton@imgtec.com> <1390836194-26286-15-git-send-email-paul.burton@imgtec.com> <52E6A7B5.2040505@gmail.com> <20140127193908.GL970@pburton-linux.le.imgtec.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 01/27/2014 11:39 AM, Paul Burton wrote:
On Mon, Jan 27, 2014 at 10:38:45AM -0800, David Daney wrote:
....
On 01/27/2014 07:23 AM, Paul Burton wrote:
No current systems implementing MSA include support for vector register
partitioning which makes it somewhat difficult to implement support for
it in the kernel. Thus for the moment the kernel includes no such
support. However if the kernel were to be run on a system which
implemented register partitioning then it would not function correctly,
mishandling MSA disabled exceptions. Calling panic when run on a system
with vector register partitioning implemented ensures that we're not
caught out by this later but instead reminded to implement support once
such a system is available.

Signed-off-by: Paul Burton <paul.burton@imgtec.com>
---
  arch/mips/kernel/cpu-probe.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
index 852e085..003ba3c 100644
--- a/arch/mips/kernel/cpu-probe.c
+++ b/arch/mips/kernel/cpu-probe.c
@@ -1193,9 +1193,13 @@ void cpu_probe(void)
        else
                c->srsets = 1;

-       if (cpu_has_msa)
+       if (cpu_has_msa) {
                c->msa_id = cpu_get_msa_id();

+               if (c->msa_id & MSA_IR_WRPF)
+                       panic("Vector register partitioning unimplemented!");

You should probably use a WARN_ON() instead.  There is no reason to crash
the kernel for this condition is there?


Well mapping vector registers reuses the MSA disabled exception, so if
the kernel were to continue with my current code & userland were to
execute an MSA instruction I believe it would appear to hang. [...]

The CPU probing things are called so early that any panic() or BUG() here will result in absolutely no console output as this code is called before any console drivers are enabled.

So the choice is really:

panic(): No output on console and system is frozen/locked-up.

WARN(): Nice stack trace on console, theoretical lockup once userspace code starts executing.

You can probably guess which I think is the better option.


Thanks,
     Paul

+       }
+
        cpu_probe_vmbits(c);

  #ifdef CONFIG_64BIT



To report this email as SPAM, please forward it to spam@websense.com





<Prev in Thread] Current Thread [Next in Thread>