linux-mips
[Top] [All Lists]

Re: [PATCH] Input: i8042-io - Exclude mips platforms when allocating/dea

To: Raghu Gandham <raghu.gandham@imgtec.com>
Subject: Re: [PATCH] Input: i8042-io - Exclude mips platforms when allocating/deallocating IO regions.
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: Sun, 26 Jan 2014 13:49:53 -0800
Cc: aaro.koskinen@iki.fi, linux-input@vger.kernel.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=tpDpFFn829fN4D7QMHijGkze98X5BbmoMUDpWf3GYac=; b=VnCtdIyZ4vkjNbRrpbDE9Xu4B2MPeosx3zwZU66YRDrP+trpJxr1JbR67Kh0Qk7m7R vDCUoHhfyOxBYBQqtI1ByL1N88j9iJWJAntVgft9UducR5I4rMDeOQEvr7peY/aBOGB4 We4JasW6RIO+5uFQwGH8quvkSLUy7tr68kcEZsmtnFHGtSJGedipcNdcHDyUvTYMyT7N 8pxhqbX9gcULCOrZx9+kcJHhgzBiWoP+5h37xnU83qFFjAg2EQO1qoxHDyPoZ71KYmWB X35cbNE5Eu4F4p+Lwu44LeoJy6jy/WVmY8E3YxH4jsohthsfOLPQOmZTh0jXm1/HlWOm jSOQ==
In-reply-to: <1390676514-30880-1-git-send-email-raghu.gandham@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1390676514-30880-1-git-send-email-raghu.gandham@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
Hi Raghu,

On Sat, Jan 25, 2014 at 11:01:54AM -0800, Raghu Gandham wrote:
> The standard IO regions are already reserved by the platform code on most MIPS
> devices(malta, cobalt, sni). The Commit 
> 197a1e96c8be5b6005145af3a4c0e45e2d651444
> ("Input: i8042-io - fix up region handling on MIPS") introduced a bug on these
> MIPS platforms causing i8042 driver to fail when trying to reserve IO ports.
> Prior to the above mentioned commit request_region is skipped on MIPS but
> release_region is called.
> 
> This patch reverts commit 197a1e96c8be5b6005145af3a4c0e45e2d651444 and also
> avoids calling release_region for MIPS.

The problem is that IO regions are reserved on _most_, but not _all_
devices. MIPS should figure out what they want to do with i8042
registers and be consistent on all devices.

I do not want to apply this patch because it will be breaking devices
using the other configuration.

Thanks.

-- 
Dmitry

<Prev in Thread] Current Thread [Next in Thread>