linux-mips
[Top] [All Lists]

Re: [PATCH] mips: don't use module_init in non-modular sead3-mtd.c code

To: <fengguang.wu@intel.com>
Subject: Re: [PATCH] mips: don't use module_init in non-modular sead3-mtd.c code
From: Paul Gortmaker <paul.gortmaker@windriver.com>
Date: Wed, 22 Jan 2014 15:39:14 -0500
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>, Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>
In-reply-to: <1390422090-24045-1-git-send-email-paul.gortmaker@windriver.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <52df8cbe.rloiJvwsOgUSEvhX%fengguang.wu@intel.com> <1390422090-24045-1-git-send-email-paul.gortmaker@windriver.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
On 14-01-22 03:21 PM, Paul Gortmaker wrote:
> The devicetree.o is built for obj-y -- and hence this code is always

I've updated the above to correct:

   s/devicetree/sead3-mtd/

Paul.
--

> present.  It will never be modular, so using module_init as an alias
> for __initcall can be somewhat misleading.
> 
> Fix this up now, so that we can relocate module_init from
> init.h into module.h in the future.  If we don't do this, we'd
> have to add module.h to obviously non-modular code, and that
> would be a worse thing.
> 
> Note that direct use of __initcall is discouraged, vs. one
> of the priority categorized subgroups.  As __initcall gets
> mapped onto device_initcall, our use of device_initcall
> directly in this change means that the runtime impact is
> zero -- it will remain at level 6 in initcall ordering.
> 
> We also fix a missing semicolon, which this change uncovers.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> 
> [patch will be added to init cleanup series:
>    http://git.kernel.org/cgit/linux/kernel/git/paulg/init.git/  ]
> 
>  arch/mips/mti-sead3/sead3-mtd.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/mips/mti-sead3/sead3-mtd.c b/arch/mips/mti-sead3/sead3-mtd.c
> index ffa35f509789..f9c890d72677 100644
> --- a/arch/mips/mti-sead3/sead3-mtd.c
> +++ b/arch/mips/mti-sead3/sead3-mtd.c
> @@ -50,5 +50,4 @@ static int __init sead3_mtd_init(void)
>  
>       return 0;
>  }
> -
> -module_init(sead3_mtd_init)
> +device_initcall(sead3_mtd_init);
> 

<Prev in Thread] Current Thread [Next in Thread>