[Top] [All Lists]

[PATCH] mips: make loongsoon serial driver explicitly modular

To: <>
Subject: [PATCH] mips: make loongsoon serial driver explicitly modular
From: Paul Gortmaker <>
Date: Wed, 22 Jan 2014 10:17:51 -0500
Cc: <>, Paul Gortmaker <>, Ralf Baechle <>, <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <>
The file looks as if it is non-modular, but it piggy-backs
off CONFIG_SERIAL_8250 which is tristate.  If set to "=m"
we will get this after the init/module header cleanup:

arch/mips/loongson/common/serial.c:76:1: error: data definition has no type or 
storage class [-Werror]
arch/mips/loongson/common/serial.c:76:1: error: type defaults to 'int' in 
declaration of 'device_initcall' [-Werror=implicit-int]
arch/mips/loongson/common/serial.c:76:1: error: parameter names (without types) 
in function declaration [-Werror]
arch/mips/loongson/common/serial.c:58:19: error: 'serial_init' defined but not 
used [-Werror=unused-function]
cc1: all warnings being treated as errors
make[3]: *** [arch/mips/loongson/common/serial.o] Error 1

Make it clearly modular, and add a module_exit function,
so that we avoid the above breakage.

Reported-by: kbuild test robot <>
Cc: Ralf Baechle <>
Signed-off-by: Paul Gortmaker <>

[patch added to init cleanup series:  ]

 arch/mips/loongson/common/serial.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/arch/mips/loongson/common/serial.c 
index 5f2b78a..4d0922f 100644
--- a/arch/mips/loongson/common/serial.c
+++ b/arch/mips/loongson/common/serial.c
@@ -11,7 +11,7 @@
 #include <linux/io.h>
-#include <linux/init.h>
+#include <linux/module.h>
 #include <linux/serial_8250.h>
 #include <asm/bootinfo.h>
@@ -72,5 +72,10 @@ static int __init serial_init(void)
        return platform_device_register(&uart8250_device);
+static void __init serial_exit(void)
+       platform_device_unregister(&uart8250_device);

<Prev in Thread] Current Thread [Next in Thread>