linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add P5600 PRid and probe support

To: John Crispin <john@phrozen.org>
Subject: Re: [PATCH] MIPS: Add P5600 PRid and probe support
From: James Hogan <james.hogan@imgtec.com>
Date: Tue, 21 Jan 2014 17:13:04 +0000
Cc: <linux-mips@linux-mips.org>
In-reply-to: <52DEA5D9.2000904@phrozen.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1390315820-15723-1-git-send-email-james.hogan@imgtec.com> <52DEA5D9.2000904@phrozen.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
Hi John,

On 21/01/14 16:52, John Crispin wrote:
>> Add a Processor ID for the P5600 core and a case in cpu_probe_mips() for
>> it. The cputype is set to CPU_PROAPTIV for now as it is in the same
>> range of cores as proAptiv and doesn't currently need to be
>> distinguished from it in the kernel.
> The "currently" in that sentence tells me that you expect there to be a
> need to distinguish it in future ?

More an "I don't know at this stage whether there'll be a need to
distinguish them in future". Even glancing at perf counters they look
the same (but I haven't checked every one).

> If this is the case, then the code should be added now rather than
> correcting the code later.
> I immediately had to think of the 1074k vs 74k patch that is in
> linux-mti-3.10 and was posted a few days ago.

Okay, fair enough, It does no real harm to re-do with a different CPU id.

Thanks
James


<Prev in Thread] Current Thread [Next in Thread>