[Top] [All Lists]

Re: [PATCH] MIPS: Add P5600 PRid and probe support

To: John Crispin <>
Subject: Re: [PATCH] MIPS: Add P5600 PRid and probe support
From: James Hogan <>
Date: Tue, 21 Jan 2014 17:13:04 +0000
Cc: <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
Hi John,

On 21/01/14 16:52, John Crispin wrote:
>> Add a Processor ID for the P5600 core and a case in cpu_probe_mips() for
>> it. The cputype is set to CPU_PROAPTIV for now as it is in the same
>> range of cores as proAptiv and doesn't currently need to be
>> distinguished from it in the kernel.
> The "currently" in that sentence tells me that you expect there to be a
> need to distinguish it in future ?

More an "I don't know at this stage whether there'll be a need to
distinguish them in future". Even glancing at perf counters they look
the same (but I haven't checked every one).

> If this is the case, then the code should be added now rather than
> correcting the code later.
> I immediately had to think of the 1074k vs 74k patch that is in
> linux-mti-3.10 and was posted a few days ago.

Okay, fair enough, It does no real harm to re-do with a different CPU id.


<Prev in Thread] Current Thread [Next in Thread>