linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add P5600 PRid and probe support

To: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Add P5600 PRid and probe support
From: John Crispin <john@phrozen.org>
Date: Tue, 21 Jan 2014 17:52:41 +0100
In-reply-to: <1390315820-15723-1-git-send-email-james.hogan@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1390315820-15723-1-git-send-email-james.hogan@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
Hi,

> Add a Processor ID for the P5600 core and a case in cpu_probe_mips() for
> it. The cputype is set to CPU_PROAPTIV for now as it is in the same
> range of cores as proAptiv and doesn't currently need to be
> distinguished from it in the kernel.
The "currently" in that sentence tells me that you expect there to be a
need to distinguish it in future ?
If this is the case, then the code should be added now rather than
correcting the code later.
I immediately had to think of the 1074k vs 74k patch that is in
linux-mti-3.10 and was posted a few days ago.

     John




> Signed-off-by: James Hogan <james.hogan@imgtec.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> ---
>  arch/mips/include/asm/cpu.h  | 1 +
>  arch/mips/kernel/cpu-probe.c | 4 ++++
>  2 files changed, 5 insertions(+)
>
> diff --git a/arch/mips/include/asm/cpu.h b/arch/mips/include/asm/cpu.h
> index 76411df3d971..b69e7306cdb1 100644
> --- a/arch/mips/include/asm/cpu.h
> +++ b/arch/mips/include/asm/cpu.h
> @@ -115,6 +115,7 @@
>  #define PRID_IMP_INTERAPTIV_MP       0xa100
>  #define PRID_IMP_PROAPTIV_UP 0xa200
>  #define PRID_IMP_PROAPTIV_MP 0xa300
> +#define PRID_IMP_P5600               0xa800
>  
>  /*
>   * These are the PRID's for when 23:16 == PRID_COMP_SIBYTE
> diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
> index 530f832de02c..7bf4634ff045 100644
> --- a/arch/mips/kernel/cpu-probe.c
> +++ b/arch/mips/kernel/cpu-probe.c
> @@ -825,6 +825,10 @@ static inline void cpu_probe_mips(struct cpuinfo_mips 
> *c, unsigned int cpu)
>               c->cputype = CPU_PROAPTIV;
>               __cpu_name[cpu] = "MIPS proAptiv (multi)";
>               break;
> +     case PRID_IMP_P5600:
> +             c->cputype = CPU_PROAPTIV;
> +             __cpu_name[cpu] = "MIPS P5600";
> +             break;
>       }
>  
>       decode_configs(c);


<Prev in Thread] Current Thread [Next in Thread>