linux-mips
[Top] [All Lists]

Re: [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler

To: David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH mips-for-linux-next] MIPS: check for -mfix-cn63xxp1 compiler option
From: Florian Fainelli <florian@openwrt.org>
Date: Wed, 15 Jan 2014 13:24:42 -0800
Cc: Linux-MIPS <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>, John Crispin <blogic@openwrt.org>, "david.daney" <david.daney@cavium.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ZUrAjJ9eta9JjWY3Et+9Jgnw4EcYyBkHFDERw4smChc=; b=z6vWdpjjLYcR71lISssOsp5R0ZhmSPym/yleAVcp1MCtIb5doij9u7GKzHfiriWWOV rdY0q5C6rfIdAWGukCdrSu4idaK/RkDl/uq03eJIfyGZB61cYOBRedNVr0X8spyZisZ/ 6MkdKaf2INlC97RkRGl4Wwt5eB8OBks7h+UiUhomilEGQXP27Kpg9Y7gY5jaTqKjXRER 5xGRiu+87rRpa23wSXdAiv7VeDRq7+W1tNGYvfnDrmMMNJ4qaG70/bBO+ju8CSZRNtj/ tKO7eEUqMdHxkHC29bmXCW6R3GLOamnLXeAif8RsG0c97PZvpYugetRNAyfJL7jq7j/v 3ccg==
In-reply-to: <CAGVrzcYQaY=0ciN-__sU34idRaiU71Sca190HTtcRkrO7-0mzg@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1389812784-30085-1-git-send-email-florian@openwrt.org> <52D6DD74.60308@caviumnetworks.com> <CAGVrzcYQaY=0ciN-__sU34idRaiU71Sca190HTtcRkrO7-0mzg@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
2014/1/15 Florian Fainelli <florian@openwrt.org>:
> 2014/1/15 David Daney <ddaney@caviumnetworks.com>:
>> On 01/15/2014 11:06 AM, Florian Fainelli wrote:
>>>
>>> Attempting to build for Cavium Octeon with an unpatched or old
>>> toolchain will fail due to the -mfix-cn63xxp1 option being unrecognized.
>>> Call cc-option on this option to make sure we can safely use it.
>>>
>>> Signed-off-by: Florian Fainelli <florian@openwrt.org>
>>
>>
>> NACK.
>>
>> If the chip you are building for needs -Wa,-mfix-cn63xxp1, then building
>> without this option yields a system the generates random errors.  So I would
>> argue that if -Wa,-mfix-cn63xxp1 is not supported by your assembler,
>> breaking the build is the proper thing to do.
>
> Fair enough. Maybe the condition should be refined to be based off
> CONFIG_CAVIUM_CN63XXP1?

Which is already the case... sorry for the noise.
-- 
Florian

<Prev in Thread] Current Thread [Next in Thread>