linux-mips
[Top] [All Lists]

Re: [PATCH 1/7] arch/mips/lantiq/xway: don't check resource with devm_io

To: Wolfram Sang <wsa@the-dreams.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] arch/mips/lantiq/xway: don't check resource with devm_ioremap_resource
From: John Crispin <john@phrozen.org>
Date: Tue, 14 Jan 2014 13:03:34 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <1389700739-3696-1-git-send-email-wsa@the-dreams.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1389700739-3696-1-git-send-email-wsa@the-dreams.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
Hi Wolfgang,

should we take 1/7 and 6/7 via the mips tree ?

    John


On 14/01/2014 12:58, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> Acked-by: John Crispin <blogic@openwrt.org>
> ---
>
> Should go via subsystem tree
>
>  arch/mips/lantiq/xway/dma.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/arch/mips/lantiq/xway/dma.c b/arch/mips/lantiq/xway/dma.c
> index 08f7ebd..78a91fa 100644
> --- a/arch/mips/lantiq/xway/dma.c
> +++ b/arch/mips/lantiq/xway/dma.c
> @@ -220,10 +220,6 @@ ltq_dma_init(struct platform_device *pdev)
>       int i;
>  
>       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -     if (!res)
> -             panic("Failed to get dma resource");
> -
> -     /* remap dma register range */
>       ltq_dma_membase = devm_ioremap_resource(&pdev->dev, res);
>       if (IS_ERR(ltq_dma_membase))
>               panic("Failed to remap dma resource");


<Prev in Thread] Current Thread [Next in Thread>