linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] MIPS: update MIPS_L1_CACHE_SHIFT based on MIPS_L1_CACHE_

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 2/3] MIPS: update MIPS_L1_CACHE_SHIFT based on MIPS_L1_CACHE_SHIFT_<N>
From: Jonas Gorski <jogo@openwrt.org>
Date: Sat, 11 Jan 2014 11:47:05 +0100
Cc: MIPS Mailing List <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>, John Crispin <blogic@openwrt.org>, Maxime Bizon <mbizon@freebox.fr>, Kevin Cernekee <cernekee@gmail.com>, "Daniel G.C." <dgcbueu@gmail.com>
In-reply-to: <1389386114-31834-3-git-send-email-florian@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1389386114-31834-1-git-send-email-florian@openwrt.org> <1389386114-31834-3-git-send-email-florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
On Fri, Jan 10, 2014 at 9:35 PM, Florian Fainelli <florian@openwrt.org> wrote:
> All platforms that require a special MIPS_L1_CACHE_SHIFT value have been
> updated, such that we can now make MIPS_L1_CACHE_SHIFT default to the
> appropriate integer value based on the select MIPS_L1_CACHE_SHIFT_<N>
> variable.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
>  arch/mips/Kconfig | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 753c5a3..123f7c0 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1106,10 +1106,10 @@ config MIPS_L1_CACHE_SHIFT_7
>
>  config MIPS_L1_CACHE_SHIFT
>         int
> -       default "4" if MACH_DECSTATION || MIKROTIK_RB532 || PMC_MSP4200_EVAL 
> || SOC_RT288X
> -       default "6" if MIPS_CPU_SCACHE
> -       default "7" if SGI_IP22 || SGI_IP27 || SGI_IP28 || SNI_RM || 
> CPU_CAVIUM_OCTEON
> -       default "5"
> +       default "4" if MIPS_L1_CACHE_SHIFT_4
> +       default "6" if MIPS_L1_CACHE_SHIFT_6
> +       default "7" if MIPS_L1_CACHE_SHIFT_7
> +       default "5" if MIPS_L1_CACHE_SHIFT_5

Having MIPS_L1_CACHE_SHIFT_5 default n and a last default "5" without
any condition to allows this to be ordered, which looks IMHO a lot
nicer ;-)


Jonas

<Prev in Thread] Current Thread [Next in Thread>