linux-mips
[Top] [All Lists]

Re: [PATCH 1/3] MIPS: introduce MIPS_L1_CACHE_SHIFT_<N>

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 1/3] MIPS: introduce MIPS_L1_CACHE_SHIFT_<N>
From: Jonas Gorski <jogo@openwrt.org>
Date: Sat, 11 Jan 2014 11:44:41 +0100
Cc: MIPS Mailing List <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>, John Crispin <blogic@openwrt.org>, Maxime Bizon <mbizon@freebox.fr>, Kevin Cernekee <cernekee@gmail.com>, "Daniel G.C." <dgcbueu@gmail.com>
In-reply-to: <1389386114-31834-2-git-send-email-florian@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1389386114-31834-1-git-send-email-florian@openwrt.org> <1389386114-31834-2-git-send-email-florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
On Fri, Jan 10, 2014 at 9:35 PM, Florian Fainelli <florian@openwrt.org> wrote:
> In order to avoid keeping an ever growing list of chips which need to
> select a specific MIPS_L1_CACHE_SHIFT value introduce multiple internal
> and non-exposed Kconfig symbols for the various MIPS_L1_CACHE_SHIFT
> values out there and update the relevant Kconfig symbols to select them.
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
>  arch/mips/Kconfig              | 18 ++++++++++++++++++
>  arch/mips/pmcs-msp71xx/Kconfig |  1 +
>  arch/mips/ralink/Kconfig       |  1 +
>  3 files changed, 20 insertions(+)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 17cc7ff..753c5a3 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -183,6 +183,7 @@ config MACH_DECSTATION
>         select SYS_SUPPORTS_128HZ
>         select SYS_SUPPORTS_256HZ
>         select SYS_SUPPORTS_1024HZ
> +       select MIPS_L1_CACHE_SHIFT_4
>         help
>           This enables support for DEC's MIPS based workstations.  For details
>           see the Linux/MIPS FAQ on <http://www.linux-mips.org/> and the
> @@ -468,6 +469,7 @@ config SGI_IP22
>         select SYS_SUPPORTS_32BIT_KERNEL
>         select SYS_SUPPORTS_64BIT_KERNEL
>         select SYS_SUPPORTS_BIG_ENDIAN
> +       select MIPS_L1_CACHE_SHIFT_7
>         help
>           This are the SGI Indy, Challenge S and Indigo2, as well as certain
>           OEM variants like the Tandem CMN B006S. To compile a Linux kernel
> @@ -488,6 +490,7 @@ config SGI_IP27
>         select SYS_SUPPORTS_BIG_ENDIAN
>         select SYS_SUPPORTS_NUMA
>         select SYS_SUPPORTS_SMP
> +       select MIPS_L1_CACHE_SHIFT_7
>         help
>           This are the SGI Origin 200, Origin 2000 and Onyx 2 Graphics
>           workstations.  To compile a Linux kernel that runs on these, say Y
> @@ -694,6 +697,7 @@ config MIKROTIK_RB532
>         select SWAP_IO_SPACE
>         select BOOT_RAW
>         select ARCH_REQUIRE_GPIOLIB
> +       select MIPS_L1_CACHE_SHIFT_4
>         help
>           Support the Mikrotik(tm) RouterBoard 532 series,
>           based on the IDT RC32434 SoC.
> @@ -1088,6 +1092,18 @@ config FW_SNIPROM
>  config BOOT_ELF32
>         bool
>
> +config MIPS_L1_CACHE_SHIFT_4
> +       bool
> +
> +config MIPS_L1_CACHE_SHIFT_5
> +       def_bool y

Won't this cause two CACHE_SHIFT_X to be y for anyone selecting one
different from 5? Making this default to n and "5" the default default
is I think the better way.


Jonas

<Prev in Thread] Current Thread [Next in Thread>