linux-mips
[Top] [All Lists]

Re: [PATCH 1/4] MIPS: BCM47XX: add Belkin F7Dxxxx board detection

To: Cody P Schafer <devel@codyps.com>
Subject: Re: [PATCH 1/4] MIPS: BCM47XX: add Belkin F7Dxxxx board detection
From: Rafał Miłecki <zajec5@gmail.com>
Date: Fri, 3 Jan 2014 07:40:54 +0100
Cc: Hauke Mehrtens <hauke@hauke-m.de>, Ralf Baechle <ralf@linux-mips.org>, blogic@openwrt.org, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=/YS2B2YEqzRMMuwdBP/XGIV4XfEsAxmIBNekU4zjTx8=; b=zVVNqnWdO/bIyGKVUZlv+lMkDGkxug4/VqVdRzXoQ98Czqkgl+QPJCUZMW1HB7mjHp xDCs1Z1TOfqBr4erO/Mm3u64yxN/X0l9b669Bva4TIX1IPETkqYFN/tPQOWC3MAKOeek aH6ghps4UH6itcRbqnNdY8b+7Vsg+q2QxNpJJHRyeqEvDbN7SG95s19srBXZJ2V3UC4Y CvOCc9jZUzmw2ItaEAnKSJC4sAGIxo4FJH+9WyaQcVcwbNL2xOqFzqt2qRUbT82OkxeT PRhPQAk+m42/oekG/vTAeyx2kKNupJ/WUosyg3Zde0tGdSsefYmRl6pht9HhDZu4gbzl vSrw==
In-reply-to: <CAPoQQ-35pFjDq7j_nLPQdCrKnibcaQCha9a5XbVJxv9UQvsW_w@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1388687138-8107-1-git-send-email-hauke@hauke-m.de> <CACna6rw1_QXXk0g9tpWVsx5G1zbNQdun5edHkSzkabVfLuxL4A@mail.gmail.com> <CAPoQQ-35pFjDq7j_nLPQdCrKnibcaQCha9a5XbVJxv9UQvsW_w@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
2014/1/2 Cody P Schafer <devel@codyps.com>:
> On Thu, Jan 2, 2014 at 1:35 PM, Rafał Miłecki <zajec5@gmail.com> wrote:
>> 2014/1/2 Hauke Mehrtens <hauke@hauke-m.de>:
>>> From: Cody P Schafer <devel@codyps.com>
>>>
>>> Add a few Belkin F7Dxxxx entries, with F7D4401 sourced from online
>>> documentation and the "F7D7302" being observed. F7D3301, F7D3302, and
>>> F7D4302 are reasonable guesses which are unlikely to cause
>>> mis-detection.
>>>
>>> It also appears that at least the F7D3302, F7D3301, F7D7301, and F7D7302
>>> have a shared boardtype and boardrev, so use that as a fallback to a
>>> "generic" F7Dxxxx board.
>>
>> Cody, Hauke: I'm starring at this patch for 10 minutes now and it's
>> still unclear for me.
>>
>> You say 3301, 3302, 7301 and 7302 have the same board_* entries
>> stating they can be treated with a generic ID entry.
>
> I included the generic BCM47XX_BOARD_BELKIN_F7DXXXX entry to catch
> those boards that we don't yet have specific entries for. It allows us
> to get the leds and buttons working mostly correctly.
>
> The specific names are included so that one can determine a more exact
> board. The stock CFE requires different images for different boards
> even though they are very similar. Hardware variations are simply
> gigabit vs 100MB switches, usb port population, led population, and
> 5Ghz radio population (none of which truly require the greater detail
> in board type).

OK, maybe this is sth I'm missing... Why we should care about CFE in
kernel? We don't talk with CFE, do we? So we don't have to know which
device's CFE is that.

-- 
Rafał

<Prev in Thread] Current Thread [Next in Thread>