linux-mips
[Top] [All Lists]

Re: [PATCH 1/4] MIPS: BCM47XX: add Belkin F7Dxxxx board detection

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH 1/4] MIPS: BCM47XX: add Belkin F7Dxxxx board detection
From: Rafał Miłecki <zajec5@gmail.com>
Date: Thu, 2 Jan 2014 22:35:48 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, blogic@openwrt.org, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, Cody P Schafer <devel@codyps.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=CNaqSlQKQ8JJBTWZi+7yiNr2VVFodTUf2VIpEe//kb8=; b=1Gm/F3mrvH7fyEx7oLyVFr1q3wP8RhpgDlfbrMX2RJmXQ6coQvjn8J+wNxiTNGNb7q RK6GRYLVUwGnv5Zz9b8snCtatFP3SeW3x5VELKbJxd6qWF8DpVyGv0yrSmAJMVOeWkwz T8lsKDt0B8wyn2QBHy1pkSKz9AofdSzu/3nTFb38726nvcJhNDn+gzVhkqZ/8CA/+VUp nu7G19Yk1SlE3mBMNbWfeWSdwNgED46B/bIUfCdVpiTPYYc6eTO5V268a5na3uDuor7M 14eE3NCI6Eil3E1Z4R3idX/ACqoKETy370H/F041kbGCAVKL1AjEdTNcZleZYnzTPb7o IDqA==
In-reply-to: <1388687138-8107-1-git-send-email-hauke@hauke-m.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1388687138-8107-1-git-send-email-hauke@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
2014/1/2 Hauke Mehrtens <hauke@hauke-m.de>:
> From: Cody P Schafer <devel@codyps.com>
>
> Add a few Belkin F7Dxxxx entries, with F7D4401 sourced from online
> documentation and the "F7D7302" being observed. F7D3301, F7D3302, and
> F7D4302 are reasonable guesses which are unlikely to cause
> mis-detection.
>
> It also appears that at least the F7D3302, F7D3301, F7D7301, and F7D7302
> have a shared boardtype and boardrev, so use that as a fallback to a
> "generic" F7Dxxxx board.

Cody, Hauke: I'm starring at this patch for 10 minutes now and it's
still unclear for me.

You say 3301, 3302, 7301 and 7302 have the same board_* entries
stating they can be treated with a generic ID entry. At the same time
you define BELKIN_F7D3301 and BELKIN_F7D3302... so they are not
identical after all? Finally what about 4302? I can see it's untested,
but for some reason you assign it to the separated enum entry. Is this
not going to share config with the generic ones?

Sorry, but it looks really messy to me.

<Prev in Thread] Current Thread [Next in Thread>