linux-mips
[Top] [All Lists]

Re: [PATCH] bcma: prevent irq handler from firing when registered

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH] bcma: prevent irq handler from firing when registered
From: Rafał Miłecki <zajec5@gmail.com>
Date: Thu, 2 Jan 2014 19:20:52 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, blogic@openwrt.org, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=wspQ7029hm39pDu+8NjqfQkl2x5EbnBj+dn8xFEhpm0=; b=sxheA60pVcBPU+AnL30gB6gdHK25amf6lyt2B/so752wMBxq8TAEKH6oVhPvhLTyzS Onn24LyuH6yMTbJ8Ww7ZqCBj0EB9I6H2UpNXjb6pQ0sI+7JuhOJGFUAZmdclummESQMp zZOBgmG3ZZAVtCp6YHzE/TV0ENSTC7f/218mk+ICXCbbBw1m8O52YBnT9YkpvMdx4u6J /eKfohL3OXNfWpU9V0j4GP/O4BGMAanygHrDsyQUB2ZUQe8l8o8657ma5q/g5S40oE3P /EY0/iSP28hZD5s6Di7hv06en/nCVfuIpiq2yMn+EgOz/A0qb8Q5XF4pLrov0dJI82k8 H/KA==
In-reply-to: <1388685668-19616-1-git-send-email-hauke@hauke-m.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1388685668-19616-1-git-send-email-hauke@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
2014/1/2 Hauke Mehrtens <hauke@hauke-m.de>:
> With this patch we prevent the irq from being fired when it is
> registered. The Hardware fires an IRQ when input signal XOR polarity
> AND gpio mask is 1. Now we are setting polarity to a vlaue so that is
> is 0 when we register it.
>
> In addition we also set the irq mask register to 0 when the irq handler
> is initialized, so all gpio irqs are masked and there will be no
> unexpected irq.

Sorry for this problem. Since the generated event was button release
one, I didn't notice this problem. Glad you were more careful when
testing it.

Thanks for the patch!

<Prev in Thread] Current Thread [Next in Thread>