[Top] [All Lists]

Re: [PATCH V4 1/2] bcma: gpio: add own IRQ domain

To: Hauke Mehrtens <>, John Crispin <>, Rafał Miłecki <>
Subject: Re: [PATCH V4 1/2] bcma: gpio: add own IRQ domain
From: Sergei Shtylyov <>
Date: Sun, 08 Dec 2013 22:24:02 +0300
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Organization: Cogent Embedded
Original-recipient: rfc822;
References: <> <> <> <> <> <>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.1.1

On 12/08/2013 09:10 PM, Hauke Mehrtens wrote:

          chip->to_irq            = bcma_gpio_to_irq;
          chip->ngpio             = 16;


Should this not be

          chip->to_irq = bcma_gpio_to_irq;

I can't find a proper documentation about that. It's definitely nicer
to use
instead of
#if defined(FOO) || defined(FOO_MODULE)

But are we supposed to use it also for a simple
#if defined(FOO)

I tried to Google about this but found only some minor flame-wars ;)

Is that documented anywhere?

The commit message has the relevant info ...

I read this and as far as I understand that when CONFIG_BCMA_HOST_SOC is
bool and not tristate "#ifdef CONFIG_BCMA_HOST_SOC" and  "#if
IS_ENABLED(CONFIG_BCMA_HOST_SOC)" will have the same effect?

You can also use IS_BUILTIN(CONFIG_BCMA_HOST_SOC) to avoid unneeded test for the modular case.


WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>