linux-mips
[Top] [All Lists]

RE: [PATCH] crash_dump: fix compilation error (on MIPS at least)

To: Vivek Goyal <vgoyal@redhat.com>
Subject: RE: [PATCH] crash_dump: fix compilation error (on MIPS at least)
From: Qais Yousef <Qais.Yousef@imgtec.com>
Date: Thu, 5 Dec 2013 08:52:06 +0000
Accept-language: en-GB, en-US
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "Andrew Morton" <akpm@linux-foundation.org>, Michael Holzheu <holzheu@linux.vnet.ibm.com>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "stable@vger.kernel.org" <stable@vger.kernel.org>
In-reply-to: <20131204213017.GJ19087@redhat.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1386172702-31266-1-git-send-email-qais.yousef@imgtec.com> <20131204213017.GJ19087@redhat.com>
Sender: linux-mips-bounce@linux-mips.org
Thread-index: AQHO8QnExmvHISq+vkaNQVlz0RPH3ppEjfmAgAC8NNA=
Thread-topic: [PATCH] crash_dump: fix compilation error (on MIPS at least)
> -----Original Message-----
> From: Vivek Goyal [mailto:vgoyal@redhat.com]
> Sent: 04 December 2013 21:30
> To: Qais Yousef
> Cc: linux-kernel@vger.kernel.org; Andrew Morton; Michael Holzheu; linux-
> mips@linux-mips.org; stable@vger.kernel.org
> Subject: Re: [PATCH] crash_dump: fix compilation error (on MIPS at least)
> 
> On Wed, Dec 04, 2013 at 03:58:22PM +0000, Qais Yousef wrote:
> >   In file included from kernel/crash_dump.c:2:0:
> >   include/linux/crash_dump.h:22:27: error: unknown type name ‘pgprot_t’
> >
> > when CONFIG_CRASH_DUMP=y
> >
> > The error was traced back to this commit:
> >
> >   9cb218131de1 vmcore: introduce remap_oldmem_pfn_range()
> >
> > include <asm/pgtable.h> to get the missing definition
> 
> pgprot_t definition for mips seems to be in asm/page.h. So why are you 
> including
> asm/pgtable.h and not asm/page.h? For other architectures it seems to be in
> other files. That means those arch will have broken compilation now.

I didn't include asm/page.h because I didn't think it'll fix the problem for 
other arches.

> 
> So question is, is there any arch specific file which one can include and be 
> covered
> for pgprot_t definition for all the arches.

I asked the same question and asm/pgtable.h was the answer.

Thanks,
Qais

> 
> Thanks
> Vivek
> 
> >
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Michael Holzheu <holzheu@linux.vnet.ibm.com>
> > Cc: Vivek Goyal <vgoyal@redhat.com>
> > Cc: <linux-mips@linux-mips.org>
> > Cc: <stable@vger.kernel.org> # 3.12
> > Reviewed-by: James Hogan <james.hogan@imgtec.com>
> > Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
> > ---
> > I haven't tried any other architecture except mips.
> > If OK this should be considered for stable 3.12 (CCed).
> >
> >  include/linux/crash_dump.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> > index fe68a5a..7032518 100644
> > --- a/include/linux/crash_dump.h
> > +++ b/include/linux/crash_dump.h
> > @@ -6,6 +6,8 @@
> >  #include <linux/proc_fs.h>
> >  #include <linux/elf.h>
> >
> > +#include <asm/pgtable.h> /* for pgprot_t */
> > +
> >  #define ELFCORE_ADDR_MAX   (-1ULL)
> >  #define ELFCORE_ADDR_ERR   (-2ULL)
> >
> > --
> > 1.7.1
> >
<Prev in Thread] Current Thread [Next in Thread>