linux-mips
[Top] [All Lists]

Re: [PATCH 5/5] spi: add bcm63xx HSSPI driver

To: Jonas Gorski <jogo@openwrt.org>
Subject: Re: [PATCH 5/5] spi: add bcm63xx HSSPI driver
From: Mark Brown <broonie@kernel.org>
Date: Wed, 4 Dec 2013 14:35:40 +0000
Cc: MIPS Mailing List <linux-mips@linux-mips.org>, linux-spi@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>, John Crispin <blogic@openwrt.org>, Florian Fainelli <florian@openwrt.org>, Kevin Cernekee <cernekee@gmail.com>, Maxime Bizon <mbizon@freebox.fr>
In-reply-to: <CAOiHx==Lp7FFCCWaSiohvdAyzErBuz5n7sUVs1+A4S1axD9qCA@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1385811726-6746-1-git-send-email-jogo@openwrt.org> <1385811726-6746-6-git-send-email-jogo@openwrt.org> <20131204133823.GS29268@sirena.org.uk> <CAOiHx==utbmYUS4BLoSaaGi91Kw5voQ2vFiA97GLmwn8yU19Dw@mail.gmail.com> <20131204140853.GU29268@sirena.org.uk> <CAOiHx==Lp7FFCCWaSiohvdAyzErBuz5n7sUVs1+A4S1axD9qCA@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Dec 04, 2013 at 03:28:25PM +0100, Jonas Gorski wrote:
> On Wed, Dec 4, 2013 at 3:08 PM, Mark Brown <broonie@kernel.org> wrote:

> > You'll need to call pm_runtime_enable() and so on to turn on runtime PM
> > in probe() and reverse that in remove() but otherwise no, just adding
> > the runtime callbacks should be fine.

> I see. Looks like I just copied your oversight from
> 5355d96d6fb56507761f261a23c0831f67fa0e0f ("spi/bcm63xx: Convert to
> core runtime PM") :P I'll add that to my list of things to fix.

The driver was already broken there - the requirement to enable runtime
PM is a part of the core runtime PM API.  All that change did was factor
out the enable and disable calls.

> Grepping through drivers/spi, I see a few drivers not calling
> pm_runtime_enable(), but setting auto_runtime_pm to true, and a few
> doing the opposite. These should probably aligned, too.

Not using the core runtime PM is fine, there may be reasons the driver
wants to do this by hand.  Things not enabling runtime PM are definitely
buggy though.

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>