linux-mips
[Top] [All Lists]

Re: [PATCH V4 1/2] bcma: gpio: add own IRQ domain

To: John Crispin <john@phrozen.org>
Subject: Re: [PATCH V4 1/2] bcma: gpio: add own IRQ domain
From: Rafał Miłecki <zajec5@gmail.com>
Date: Fri, 29 Nov 2013 21:53:29 +0100
Cc: "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>, Hauke Mehrtens <hauke@hauke-m.de>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=Bn7cBoXiv23hWnfKNP6u1sn6QsAc+b2foLtzncV32Zw=; b=lYwB9Dx5Dqhx51pi9yif1C9mFTHqyCnaqvOLei8NGnPLc2kl0bsYAqyJIsJpBI0mcR faui/1n5LlPJMB1UlgUYZFE4E59f8zz6ZaaZHLrapdIWmLC8qg7J6PTtWid/RCy8DMX8 dt0W4wLXhfrA38scz3ZCL8cVXbbawL43bgC1uoLkYIzPEGRcCWJxmUM1u33bXs6NlwW+ 5yHabix4X0dq7WOyFOtLCCx2Q9GlpVn4ACQcU9mxly4vj/gVE7scCYw6Wfq9hHYcQCSd /sBFLZu+Lrt//hqTeU3Fl9KVjYdM9LAAYQ1CCweYRbobIJd1c5wwjxBV2rMjcHC0kfzy sRwg==
In-reply-to: <5298FAED.7020408@phrozen.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1385747290-22575-1-git-send-email-zajec5@gmail.com> <1385752379-19540-1-git-send-email-zajec5@gmail.com> <5298FAED.7020408@phrozen.org>
Sender: linux-mips-bounce@linux-mips.org
2013/11/29 John Crispin <john@phrozen.org>:
> On 29/11/13 20:12, Rafał Miłecki wrote:
>>
>> +#ifdef CONFIG_BCMA_HOST_SOC
>>         chip->to_irq            = bcma_gpio_to_irq;
>> +#endif
>>         chip->ngpio             = 16;
>
>
>
> Hi,
>
> Should this not be
>
> if (IS_ENABLED(CONFIG_BCMA_HOST_SOC))
>         chip->to_irq = bcma_gpio_to_irq;

I can't find a proper documentation about that. It's definitely nicer to use
#if IS_ENABLED(FOO)
instead of
#if defined(FOO) || defined(FOO_MODULE)

But are we supposed to use it also for a simple
#if defined(FOO)
?

I tried to Google about this but found only some minor flame-wars ;)

Is that documented anywhere?

-- 
Rafał

<Prev in Thread] Current Thread [Next in Thread>