linux-mips
[Top] [All Lists]

Re: [PATCH V4 1/2] bcma: gpio: add own IRQ domain

To: Rafał Miłecki <zajec5@gmail.com>
Subject: Re: [PATCH V4 1/2] bcma: gpio: add own IRQ domain
From: John Crispin <john@phrozen.org>
Date: Fri, 29 Nov 2013 21:37:01 +0100
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>, Hauke Mehrtens <hauke@hauke-m.de>
In-reply-to: <1385752379-19540-1-git-send-email-zajec5@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1385747290-22575-1-git-send-email-zajec5@gmail.com> <1385752379-19540-1-git-send-email-zajec5@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
On 29/11/13 20:12, Rafał Miłecki wrote:
+#ifdef CONFIG_BCMA_HOST_SOC
        chip->to_irq         = bcma_gpio_to_irq;
+#endif
        chip->ngpio          = 16;


Hi,

Should this not be

if (IS_ENABLED(CONFIG_BCMA_HOST_SOC))
        chip->to_irq = bcma_gpio_to_irq;


        John

<Prev in Thread] Current Thread [Next in Thread>