linux-mips
[Top] [All Lists]

Re: [PATCH v2] panic: Make panic_timeout configurable

To: ralf@linux-mips.org, jbaron@akamai.com
Subject: Re: [PATCH v2] panic: Make panic_timeout configurable
From: Shinya Kuribayashi <skuribay@pobox.com>
Date: Tue, 19 Nov 2013 23:51:27 +0900
Cc: mingo@kernel.org, benh@kernel.crashing.org, paulus@samba.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, florian@openwrt.org, jchandra@broadcom.com, ganesanr@broadcom.com
Dkim-signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=message-id :date:from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; s=sasl; bh=W192lIKeVNc9 P6q/OTyeOH1efKQ=; b=mUQLC6ldJRfX5DWEXSC7BVozhUT3I+S8ddL9uNF9IbVX 3MCGPOp6+qgNjpoOyGNGwf80yXstFJSw8/106ESR+Djiygu9WY1Uc564xqATH7oB VY2lGQwmrTP1MnR0X+7qExdITJLi5hO5nnQuTPZhZMFmkHxWlAfo+uNPRi0HJmg=
Domainkey-signature: a=rsa-sha1; c=nofws; d=pobox.com; h=message-id:date :from:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; q=dns; s=sasl; b=xXTQop qd87aA9CrlKOrUcV/BctiiryyWtPYHFCp0W4Y4vKZNFRMqqmitE8QcbIgusyGP5s g5urkZ8IFHqLptnRCeFj+1ym9lHtgceSzsrbVCCPj7emx4RE+CBmiOdA09xYmIrA cEFcWIKaYH4cE6nKMXslOXwKHMUPCCu6mXU/E=
In-reply-to: <20131119090211.GN10382@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20131118210436.233B5202A@prod-mail-relay06.akamai.com> <20131119090211.GN10382@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 11/19/13 6:02 PM, Ralf Baechle wrote:> On Mon, Nov 18, 2013 at 09:04:36PM 
+0000, Jason Baron wrote:
It's more complicated - MIPS was using the global default with five MIPS
platforms overriding the default.

I propose to kill these overrides for sanity unless somebody comes up
with a good argument.  Patch below.

   Ralf

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

  arch/mips/ar7/setup.c           | 1 -
  arch/mips/emma/markeins/setup.c | 3 ---
  arch/mips/netlogic/xlp/setup.c  | 1 -
  arch/mips/netlogic/xlr/setup.c  | 1 -
  arch/mips/sibyte/swarm/setup.c  | 2 --
  5 files changed, 8 deletions(-)
[...]
diff --git a/arch/mips/emma/markeins/setup.c b/arch/mips/emma/markeins/setup.c
index d710058..9100122 100644
--- a/arch/mips/emma/markeins/setup.c
+++ b/arch/mips/emma/markeins/setup.c
@@ -111,9 +111,6 @@ void __init plat_mem_setup(void)
        iomem_resource.start = EMMA2RH_IO_BASE;
        iomem_resource.end = EMMA2RH_ROM_BASE - 1;

-       /* Reboot on panic */
-       panic_timeout = 180;
-
        markeins_sio_setup();
  }


IIRC we had set it to 180 seconds for some historical reasons, but
I'm afraid nobody can recall the reason why it's set so in 2013...
Anyway I was thinking it too long and reduced to a few seconds locally
when debugging, so there shouldn't be a problem with this change.

FWIW, for EMMA2RH portion:

Acked-by: Shinya Kuribayashi <skuribay@pobox.com>

Thank you always for your help, Ralf.

<Prev in Thread] Current Thread [Next in Thread>