linux-mips
[Top] [All Lists]

Re: [PATCH 3/6] MIPS: Add support for the proAptiv cores

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH 3/6] MIPS: Add support for the proAptiv cores
From: Markos Chandras <Markos.Chandras@imgtec.com>
Date: Tue, 12 Nov 2013 09:41:55 +0000
Cc: <linux-mips@linux-mips.org>, Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
In-reply-to: <5281370C.8040707@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1383844120-29601-1-git-send-email-markos.chandras@imgtec.com> <1383844120-29601-4-git-send-email-markos.chandras@imgtec.com> <5281370C.8040707@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0
On 11/11/2013 07:59 PM, David Daney wrote:

This patch is a big collection of small unrelated changes.

Can you break it up so that there is one patch per change?

o Add new identifiers
o Probe for them.
o Add new cpu-features.
o tlb.h change.
o All the places you add 'case CPU_PROAPTIV'


Hi David,

Ok thanks I will split this patch into smaller patches.

[...]
diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
index c814287..8168e29 100644
--- a/arch/mips/kernel/cpu-probe.c
+++ b/arch/mips/kernel/cpu-probe.c
@@ -286,6 +286,13 @@ static inline unsigned int decode_config4(struct
cpuinfo_mips *c)
          && cpu_has_tlb)
          c->tlbsize += (config4 & MIPS_CONF4_MMUSIZEEXT) * 0x40;

+    if (cpu_has_tlb) {
+        if (((config4 & MIPS_CONF4_IE) >> 29) == 2) {
+            c->options |= MIPS_CPU_TLBINV;
+            pr_info("TLBINV/F supported, config4=0x%0x\n", config4);

... The probing functions don't print messages, so don't add this
pr_info().

Ok will do

Thanks for the review

--
markos


<Prev in Thread] Current Thread [Next in Thread>